Fix box shadow colour of "tertiary-on-primary" button #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "tertiary-on-primary" button has a transparent background and border, and it is meant to be shown on an element with primary colour. Due to this the colour of the box shadow should be the primary text colour rather than the default main text colour. Otherwise it would change depending on light / dark mode, even if the button text and the background it is shown on do not. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
bug
nickvergessen
approved these changes
Jul 25, 2022
marcoambrosini
approved these changes
Jul 25, 2022
marcoambrosini
deleted the
fix-box-shadow-colour-of-tertiary-on-primary-button
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2871
Before:
After:
