Always show NcAppSettingsDialog title #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
added
bug
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
requested review from
skjnldsv,
juliusknorr,
marcoambrosini,
nickvergessen,
vinicius73,
GretaD and
jotoeri
marcoambrosini
approved these changes
Aug 19, 2022
skjnldsv
approved these changes
Aug 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
NcAppSettingsDialogto always show the title element, independent of whether a title is set or not.This allows to click the modal close button even if no title is given. Before it was visible, but not clickable, since it was hidden behind the dialogs content. Closes #3029.
Check by removing the
titleprop ofNcAppSettingsDialog.