Fix the NcPopoverMenu component #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just overwrite some style from server Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
julien-nc and
GretaD
and removed request for
a team
|
Fine with me. But wouldn't it be better to migrate server from NcPopoverMenu (which is deprecated) to NcActions? |
|
Definitively better but also more work Yesterday, I ported groupfolders app away from the NcPopoverMenu and I might do the same to notificationsupdate tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just overwrites some style from the server
Before
After: some spacing between the items and not a ridiculously big border-radius