Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overwriting placeholder property in NcDatetimePicker #3202

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fix overwriting placeholder property in NcDatetimePicker #3202

merged 1 commit into from
Sep 9, 2022

Conversation

Chartman123
Copy link
Contributor

This fixes an issue in Forms where the placeholder for NcDatetimePicker cannot be overwritten by passing some text to the property: nextcloud/forms#1296

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added bug Something isn't working 3. to review Waiting for reviews labels Sep 8, 2022
@jotoeri
Copy link
Contributor

jotoeri commented Sep 8, 2022

Can you remove the this. from the default-translations, too? So from this.t('Pick a time') make t('Pick a time'). Then run npm run l10n:extract and commit the pot with it.

Then, regarding the components, we have in this PR:

  • Fixing translations of the Placeholder of DatePicker
  • Adding the possibility to pass custom Placeholders

@Chartman123 Chartman123 force-pushed the fix/NcDatetimePicker_placeholder branch from a5056f4 to 72d3404 Compare September 8, 2022 18:27
@Chartman123 Chartman123 linked an issue Sep 8, 2022 that may be closed by this pull request
Some text is not localized for "ru" locale nextcloud/forms#1296
Closed
@Chartman123 Chartman123 force-pushed the fix/NcDatetimePicker_placeholder branch from 72d3404 to c034b32 Compare September 8, 2022 18:55
@Chartman123
Fix overwriting placeholder property
dae7c21 
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 force-pushed the fix/NcDatetimePicker_placeholder branch from a7d7b73 to dae7c21 Compare September 8, 2022 20:35
@Chartman123 Chartman123 merged commit b723408 into master Sep 9, 2022
@Chartman123 Chartman123 deleted the fix/NcDatetimePicker_placeholder branch September 9, 2022 06:57
@Chartman123
Copy link
Contributor Author

Should we also backport this to the current releases?

@jotoeri
Copy link
Contributor

jotoeri commented Sep 9, 2022

/backport to stable6

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 9, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Oct 29, 2022
Merged
@skjnldsv
Copy link
Contributor

Can you remove the this. from the default-translations, too? So from this.t('Pick a time') make t('Pick a time').

This broke the component: fix in #3405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@jotoeri jotoeri jotoeri approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some text is not localized for "ru" locale
4 participants
@Chartman123 @jotoeri @skjnldsv @CarlSchwan