Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use @nextcloud/focus-trap instead of focus-trap #3347

Merged
merged 1 commit into from
Oct 13, 2022
Merged

use @nextcloud/focus-trap instead of focus-trap #3347

merged 1 commit into from
Oct 13, 2022

Conversation

vinicius73
Copy link
Contributor

@vinicius73 vinicius73 commented Oct 5, 2022 •
edited by skjnldsv
Loading

@vinicius73 vinicius73 added enhancement New feature or request 2. developing Work in progress high High priority accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Oct 5, 2022
@skjnldsv skjnldsv marked this pull request as ready for review October 5, 2022 16:28
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 5, 2022
@skjnldsv
Copy link
Contributor

skjnldsv commented Oct 5, 2022

/backport to stable6

@vinicius73 vinicius73 changed the title [WIP] use @nextcloud/focus-trap instead of focus-trap use @nextcloud/focus-trap instead of focus-trap Oct 6, 2022
🚧 use @nextcloud/focus-trap instead of focus-trap
25b7d76 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
ChristophWurst
ChristophWurst approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv merged commit 7e3800d into master Oct 13, 2022
@skjnldsv skjnldsv deleted the feature/add-nc-focus-trap branch October 13, 2022 12:33
@skjnldsv
Copy link
Contributor

Oh, 7 was released before this went in?? 😞

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 13, 2022
Merged
@raimund-schluessler raimund-schluessler mentioned this pull request Oct 14, 2022
Closed
@nickvergessen nickvergessen added this to the 7.0.1 milestone Oct 14, 2022
@skjnldsv skjnldsv mentioned this pull request Oct 14, 2022
Merged
@vinicius73 vinicius73 mentioned this pull request Oct 18, 2022
Closed
@artonge artonge mentioned this pull request Oct 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request high High priority
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.

Recursive calls of focusTrap() in NcActions component
4 participants
@vinicius73 @skjnldsv @ChristophWurst @nickvergessen