Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand color picker width only when using advanced fields #3410

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Expand color picker width only when using advanced fields #3410

merged 1 commit into from
Nov 1, 2022

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 31, 2022

Before After
image image

Advanced fields
image

@Pytal
Expand color picker width only when using advanced fields
0388b43 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: colorpicker Related to the colorpicker component labels Oct 31, 2022
@Pytal Pytal added this to the 7.0.2 milestone Oct 31, 2022
@Pytal Pytal self-assigned this Oct 31, 2022
mejo-
mejo- approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me 👌

Failed cypress tests seem unrelated, given that the very same tests already fail on latest master.

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 1, 2022
@Pytal Pytal merged commit a9d7419 into master Nov 1, 2022
@Pytal Pytal deleted the fix/color-picker-width branch November 1, 2022 18:37
@skjnldsv skjnldsv mentioned this pull request Nov 15, 2022
Merged
@skjnldsv skjnldsv modified the milestones: 7.0.2, 7.1.0 Nov 16, 2022
@nickvergessen
Copy link
Contributor

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@szaimen szaimen szaimen approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: colorpicker Related to the colorpicker component
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @nickvergessen @mejo- @szaimen @skjnldsv