-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NcHeaderMenu #3489
Add NcHeaderMenu #3489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was gifted a similar component in the notifications app by @CarlSchwan
https://github.com/nextcloud/notifications/blob/master/src/Components/HeaderMenu.vue
Can we look that it can cover both cases?
Sorry... I read the sample not the actual template... |
Carl took mine from server 🙈 |
dd32d29
to
7e22b5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the minor eslint errors
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
7e22b5e
to
e5875db
Compare
Fixed! 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, but good otherwise :)
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Since we're positioning it fixed on nextcloud the live example is not as great as this example, but it works out.
From https://github.com/nextcloud/server/blob/abaa3ef61b9a6177ca3fe965e837e6e9bca16a4b/core/src/views/UnifiedSearch.vue