Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value type for DateTimePickerNative #3491

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix value type for DateTimePickerNative #3491

merged 1 commit into from
Nov 17, 2022

Conversation

skjnldsv
Copy link
Contributor

Fix #3403

@skjnldsv
Fix value type for DateTimePickerNative
ba7c3a4 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component labels Nov 17, 2022
@skjnldsv skjnldsv added this to the 7.1.0 milestone Nov 17, 2022
@skjnldsv skjnldsv self-assigned this Nov 17, 2022
@skjnldsv skjnldsv requested review from artonge and Pytal and removed request for a team November 17, 2022 15:37
szaimen
szaimen approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me. I hope this does not break nextcloud/server#35207 again?

@PVince81
Copy link
Contributor

@szaimen it won't. In that ticket/PR we switched to Date. The reason it was broken was because it was wrongly set to use a String

PVince81
PVince81 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit cf51b78 into master Nov 17, 2022
@PVince81 PVince81 deleted the fix/datetime-proptype branch November 17, 2022 15:47
artonge
artonge reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the jsDoc of this method: https://github.com/nextcloud/nextcloud-vue/blob/ba7c3a42c5133d495a3a80603874aa6289d2c70a/src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue#L330-L336

@nickvergessen
Copy link
Contributor

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 17, 2022
Closed
@skjnldsv skjnldsv mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge left review comments

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working feature: datepicker Related to the date/time picker component
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

ActionInput date ignores given value when using strings
5 participants
@skjnldsv @PVince81 @nickvergessen @artonge @szaimen