Allow accessible labels for NcActionInput #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
enhancement
Pytal
requested review from
nickvergessen,
raimund-schluessler,
JuliaKirschenheuter,
CarlSchwan and
marcoambrosini
6 tasks
PVince81
reviewed
Dec 5, 2022
|
/rebase |
nextcloud-command
force-pushed
the
enh/a11y-action-input-label
branch
from
569982b
to
415790c
Compare
JuliaKirschenheuter
requested changes
Dec 7, 2022
Pytal
force-pushed
the
enh/a11y-action-input-label
branch
from
415790c
to
4f360f2
Compare
JuliaKirschenheuter
approved these changes
Dec 9, 2022
Pytal
force-pushed
the
enh/a11y-action-input-label
branch
2 times, most recently
from
52d1348
to
39b2e08
Compare
|
Public API is stable, the breaking label is for the DOM structure @marcoambrosini? Edit: Removing label, can be added back if indeed breaking |
skjnldsv
reviewed
Dec 15, 2022
Pytal
force-pushed
the
enh/a11y-action-input-label
branch
from
39b2e08
to
2bd0274
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-action-input-label
branch
from
2bd0274
to
2cd5946
Compare
Pytal
added
4. to release
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Feb 14, 2023
The internal dom structure was changed by nextcloud-libraries/nextcloud-vue#3517 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Feb 14, 2023
The internal dom structure was changed by nextcloud-libraries/nextcloud-vue#3517 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Feb 14, 2023
The internal dom structure was changed by nextcloud-libraries/nextcloud-vue#3517 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought over from NcInputField and switched
labelVisibledefault totruehttps://github.com/nextcloud/nextcloud-vue/blob/1dc8ed09c47d482a7a9cf8ae89babbd15f209aee/src/components/NcInputField/NcInputField.vue#L147-L155
https://github.com/nextcloud/nextcloud-vue/blob/1dc8ed09c47d482a7a9cf8ae89babbd15f209aee/src/components/NcInputField/NcInputField.vue#L167-L175
https://github.com/nextcloud/nextcloud-vue/blob/1dc8ed09c47d482a7a9cf8ae89babbd15f209aee/src/components/NcInputField/NcInputField.vue#L370-L382
Example