Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add console warning messages for deprecated multiselect components #3573

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Add console warning messages for deprecated multiselect components #3573

merged 2 commits into from
Jan 4, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Dec 16, 2022

image

As discussed #2951 (comment)

For developers in addition to the existing deprecation badges in the docs
image
image

@Pytal Pytal added 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Dec 16, 2022
@Pytal Pytal added this to the 7.2.1 milestone Dec 16, 2022
@Pytal Pytal self-assigned this Dec 16, 2022
@skjnldsv skjnldsv modified the milestones: 7.2.1, 7.3.0 Dec 16, 2022
@nickvergessen
Copy link
Contributor

FAIL tests/unit/components/NcMultiselect/NcMultiselect.spec.js
● Test suite failed to run

ReferenceError: PRODUCTION is not defined

  248 | import VueMultiselect from 'vue-multiselect'
  249 |
> 250 | if (!PRODUCTION) {
      | ^
  251 | 	console.warn('NcMultiselect usage has been deprecated. Use NcSelect instead.')
  252 | }
  253 |

  at Object.<anonymous> (src/components/NcMultiselect/NcMultiselect.vue:250:1)
  at Object.<anonymous> (tests/unit/components/NcMultiselect/NcMultiselect.spec.js:24:1)

Pytal added 2 commits January 4, 2023 10:58
@Pytal
Define PRODUCTION global variable
3fe3aea 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Add deprecation console warning messages for multiselect components
4df172a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/console-deprecate-multiselect branch from 38fda38 to 4df172a Compare January 4, 2023 18:58
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 4, 2023
@Pytal Pytal merged commit 302656e into master Jan 4, 2023
@Pytal Pytal deleted the enh/console-deprecate-multiselect branch January 4, 2023 19:08
@Pytal Pytal added the deprecation Related to the deprecation of anything available on the public API label Jan 4, 2023
This was referenced Jan 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish deprecation Related to the deprecation of anything available on the public API feature: select Related to the NcSelect* components
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @nickvergessen @artonge @skjnldsv