Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard focus border to select options #3711

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add keyboard focus border to select options #3711

merged 1 commit into from
Feb 2, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Feb 1, 2023

Before After
image image

@Pytal
Add keyboard focus border to select options
c229ce2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: select Related to the NcSelect* components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Feb 1, 2023
@Pytal Pytal added this to the 7.6.0 milestone Feb 1, 2023
@Pytal Pytal self-assigned this Feb 1, 2023
@JuliaKirschenheuter JuliaKirschenheuter merged commit 6b9fe86 into master Feb 2, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the enh/a11y-select-kb-focus branch February 2, 2023 08:00
@Pytal Pytal mentioned this pull request Feb 3, 2023
Closed
6 tasks
@Pytal Pytal added the enhancement New feature or request label Feb 4, 2023
@Pytal Pytal mentioned this pull request Feb 15, 2023
Merged
@Pytal Pytal mentioned this pull request Feb 22, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: select Related to the NcSelect* components
Projects
None yet
Milestone
7.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @JuliaKirschenheuter @artonge