Fix NcButton cursor style
#3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
bug
raimund-schluessler
force-pushed
the
fix/noid/button-cursor
branch
from
b3b1d18
to
bceb005
Compare
raimund-schluessler
requested review from
skjnldsv,
susnux,
marcoambrosini and
artonge
|
So this is for |
Well, it's supposed to be for the material design icon spans. But if you are worried that it messes with spans you put in the slot, I think it should also work without the :deep(). |
|
No i just wondered why the |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/noid/button-cursor
branch
from
718b82a
to
ffce493
Compare
Yes, I used it for the nested material design icons, just to be sure. But it seems to work without it as well, so I removed it now. |
marcoambrosini
approved these changes
Feb 7, 2023
Pytal
approved these changes
Feb 8, 2023
susnux
approved these changes
Feb 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nextcloud server has a CSS rule
span { cursor: default; }that would sometimes (depending on the order in which the bundle is loaded) overwrite the button cursor style. This should make it more explicit so it takes precedence over the server style.