Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the smart picker modal padding #3962

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

julien-nc
Copy link
Contributor

@julien-nc julien-nc commented Apr 7, 2023

  • Remove it to let custom picker components set it if needed.
  • Adjust the padding of the generic search.
  • Make one class more explicit

This allows, for example, custom picker components that have infinite scrolling (like the Giphy integration one) to remove bottom padding/margin which looks better.

As we can't make sure nextcloud/vue is updated everywhere at once and all the providers are adjusted (I'll make sure most of them are 😁 ), we might temporarily have:

  • double padding with adjusted providers displayed in apps using an old nextcloud/vue release
  • no padding at all for old providers displayed in apps using a nextcloud/vue release which includes those changes

Not that bad IMO.

… choose it, add padding to the generic search

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added enhancement New feature or request 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Apr 7, 2023
@julien-nc julien-nc added this to the 7.9.1 milestone Apr 7, 2023
Copy link
Contributor

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-nc seems sensible to me. Could you provide a (non-comprehensive) list of apps with picker componenents that are not under your umbrella? 😬

@julien-nc
Copy link
Contributor Author

@mejo- Thanks for the review. So far I'm not aware of many providers implementing a custom picker component.
Appart from mines, there is the Files one implemented by @juliushaertl and that's about it I think.

@juliushaertl juliushaertl merged commit 6b2d8a3 into master Apr 12, 2023
@juliushaertl juliushaertl deleted the enh/noid/remove-smart-picker-modal-padding branch April 12, 2023 12:56
@Pytal Pytal mentioned this pull request Apr 17, 2023
@AndyScherzinger AndyScherzinger modified the milestones: 7.9.1, 7.10.0 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants