Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcHeaderMenu): fix unnecessary filter invert #3974

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fix(NcHeaderMenu): fix unnecessary filter invert #3974

merged 1 commit into from
Apr 14, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Apr 14, 2023 •
edited
Loading

  • This was here for legacy menus that were still using icon classes
  • Because this is a vue component, it means apps using it are already using svg (notifications, settings menu, contacts menu, search... etc)

This also fixes the weird avatar invert bug
Fix nextcloud/server#37379

@skjnldsv
fix(NcHeaderMenu): fix unnecessary filter invert
32396a6 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Apr 14, 2023
@skjnldsv skjnldsv self-assigned this Apr 14, 2023
@skjnldsv skjnldsv requested a review from artonge April 14, 2023 09:07
@skjnldsv skjnldsv mentioned this pull request Apr 14, 2023
Closed
9 tasks
szaimen
szaimen approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@skjnldsv skjnldsv merged commit c7ccc10 into master Apr 14, 2023
@skjnldsv skjnldsv deleted the fix/header-invert branch April 14, 2023 10:07
@Pytal Pytal mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@szaimen szaimen szaimen approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@Pytal Pytal Awaiting requested review from Pytal

@artonge artonge Awaiting requested review from artonge

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Avatar thumbnail (status indicator) colours inverted after upgrade to 25.0.5 or 26.0.0
3 participants
@skjnldsv @nickvergessen @szaimen