fix(NcRichContenteditable): Also quote ids containing a slash #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
nickvergessen
force-pushed
the
bugfix/noid/also-quote-slash-ids
branch
from
9e544c4
to
d88dbdb
Compare
ShGKme
reviewed
May 3, 2023
This is e.g. the case with guests and groups in talk Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/also-quote-slash-ids
branch
from
d88dbdb
to
6c5ab3b
Compare
Antreesy
approved these changes
May 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is e.g. the case with guests and user groups in talk.
It's the follow up to the removal of the quotes in talk from nextcloud/spreed#9420 which previously caused double quoting for users and groups with a space. But now groups and guests without a space are no longer quoted.