Skip to content

Commit

Permalink
remove redundant configuration from unattended upgrades
Browse files Browse the repository at this point in the history
  • Loading branch information
nacho committed Feb 18, 2018
1 parent e965c1a commit 4bdbf93
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
10 changes: 9 additions & 1 deletion changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@

[v0.46.12](https://github.com/nextcloud/nextcloudpi/commit/2eda867) (2018-02-15) lamp: protect apache fingerprinting
[v0.46.16](https://github.com/nextcloud/nextcloudpi/commit/93d58f2) (2018-02-16) remove redundant configuration from unattended upgrades

[v0.46.15](https://github.com/nextcloud/nextcloudpi/commit/45c5608) (2018-02-16) lamp: enhance SSL security (chacha cypher), and OCSP stapling

[v0.46.14](https://github.com/nextcloud/nextcloudpi/commit/90dc944) (2018-02-16) log all NCP actions to /var/log/ncp.log

[v0.46.13](https://github.com/nextcloud/nextcloudpi/commit/19b0609) (2018-02-16) update: accept github branch as an argument to ncp-update to test development branch

[v0.46.12](https://github.com/nextcloud/nextcloudpi/commit/629ba33) (2018-02-15) lamp: protect apache fingerprinting

[v0.46.11](https://github.com/nextcloud/nextcloudpi/commit/04ebdea) (2018-02-15) SSH: dont create user if it doesnt exist

Expand Down
4 changes: 4 additions & 0 deletions update.sh
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,10 @@ EOF
sed -i 's|^ServerSignature .*|ServerSignature Off|' /etc/apache2/conf-enabled/security.conf
sed -i 's|^ServerTokens .*|ServerTokens Prod|' /etc/apache2/conf-enabled/security.conf

# remove redundant configuration from unattended upgrades
[[ "$( ls -l /etc/php/7.0/fpm/conf.d/*-opcache.ini | wc -l )" -gt 1 ]] && rm "$( ls /etc/php/7.0/fpm/conf.d/*-opcache.ini | tail -1 )"
[[ "$( ls -l /etc/php/7.0/cli/conf.d/*-opcache.ini | wc -l )" -gt 1 ]] && rm "$( ls /etc/php/7.0/cli/conf.d/*-opcache.ini | tail -1 )"

# upgrade launcher after logging improvements
cat > /home/www/ncp-launcher.sh <<'EOF'
#!/bin/bash
Expand Down

2 comments on commit 4bdbf93

@ovpc
Copy link
Collaborator

@ovpc ovpc commented on 4bdbf93 Dec 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot load Zend OPcache - it was already loaded

Came back again! in v0.67.5 on Debian9 after a manual apt update&&upgrade (php7.2 and php7.2-opcache:amd64 got updated)
Although I know it is harmless, I patched it with
sudo rm /etc/php/7.2/cli/conf.d/20-opcache.ini
It got re-created during upgrade, while 10-opcache.ini was and still is present
(Just updated to v0.67.6 but that adds the missing PHPVER=7.2)
As I removed 20- earlier and this time again.
I just renamed 10-opcache.ini to 20-opcache.ini to avoid this reoccurring.
Correct?

@nachoparker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that would prevent it from happening again, this is getting annoying

Please sign in to comment.