Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of database column MODIFIED #166

Closed
korelstar opened this issue Jan 20, 2017 · 6 comments
Closed

Type of database column MODIFIED #166

korelstar opened this issue Jan 20, 2017 · 6 comments
Milestone

Comments

@korelstar
Copy link
Member

Currently, the modified column in the database is of type TEXT (using the format yyyy-MM-dd HH:mm:ss). Is there a reason for that? In my view, it should be of type INTEGER (using the unix epoch), since this should require less space, sorting should be faster etc. But maybe, I've overseen something.

@stefan-niedermann
Copy link
Member

No reason, we can switch to unix timestamps, but if you want to implement it, think about the update method of the app, so older clients are migrating it correctly. We will have to test it well.

@stefan-niedermann
Copy link
Member

@korelstar is this issue part of your speed-up-project? I lately saw #167 is outdated. Can i support you to get this merged into master?

@korelstar
Copy link
Member Author

No, this was not part of my speed-up-project. Currently, I'm not working on this issue. It has very low priority for me since I'm not expecting that the change of the type will have large effects. However, in long-term, I still think the change to INTEGER is a good idea. So please feel free to do something, here.

I hope, I'll find some time in the near future to update #167. But this depends on a rework of nextcloud/notes#51 and there are other things in the pipeline ... but I will definitely do that. :-)

@schaarsc
Copy link
Contributor

anyone working on this issue?

@stefan-niedermann
Copy link
Member

nope

@stefan-niedermann
Copy link
Member

Fixed by #416

@stefan-niedermann stefan-niedermann added this to the 0.18.0 milestone Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants