Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it really needed to reload the notes when leaving the about and settings menu? #502

Closed
radoeka opened this issue Nov 18, 2018 · 2 comments

Comments

@radoeka
Copy link

radoeka commented Nov 18, 2018

Just wondering is it really to check for updated notes, after visiting the menu options: about and settings.

When visiting about, nothing is changed in that menu, is that require a update from the server anyway?

Similar for the settings menu, especially when no changes are made at all. Perhaps some of the settings require a update, perhaps that can be memorized by app, and only contact the server when leaving the settings menu and the need to contact the server has been set.

(I think that the app should avoid to contact the server as much as possible, especially when connected mobile 3G/4G)

@stefan-niedermann
Copy link
Member

We currently do not have conflict handling (like merging) and for this reason we try to update the notes as often as possible, so we can avoid conflicts. I understand, that not everyone has always wi-fi and limited data (e. g. indeed i only have 200 MB per month myself) - but unless we do not have a conflict handling solution (see #406 and #161) it's better to "waste" data than data loss. Instead of pulling based on a timer (which would be even worse), we decided to refresh everytime when the user might probably make changes to the notes)

(closing this as it would be resolved if the linked issues will be fixed, don't feel offended, we can talk about it, it's just for issue tracking :) )

Hope this clearifys the reasons behind this decision.

@radoeka
Copy link
Author

radoeka commented Nov 18, 2018

Thanks. And no offence, just thanks for a useful app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants