Error after updating to 4.9.0

[MattDHill]

Please make a clear and concise description of what the bug is.

Steps to reproduce

1. Update to 4.9.0
2. Notes app unable to load notes. Notes do show in dashboard widget.

Expected behaviour

Should display

Actual behaviour

On screen error shows Error from Nextcloud server: Reading notes from filesystem has failed. (Error)

Logs display

Error	index	TypeError: OCA\Notes\Controller\NotesController::__construct(): Argument #10 ($userId) must be of type string, null given

    <<closure>>

    OCA\Notes\Controller\NotesController->__construct("notes", [ "OC\\AppFr ... "], [ "OCA\\Note ... "], [ "OC\\Files ... "], [ "OCA\\Note ... "], [ "OCA\\Note ... ]], [ "OC\\AllConfig"], [ "OC\\L10N\\LazyL10N"], [ "OC\\Files\\Type\\Detection"], null)

    /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php - line 108:

    ReflectionClass->newInstanceArgs([ "notes",[ ... "])

    /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php - line 116:

    OC\AppFramework\Utility\SimpleContainer->buildClass([ "Reflectio ... "])

    /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php - line 133:

    OC\AppFramework\Utility\SimpleContainer->resolve("OCA\\Notes\ ... r")

    /var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php - line 466:

    OC\AppFramework\Utility\SimpleContainer->query("OCA\\Notes\ ... r")

    /var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php - line 438:

    OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("OCA\\Notes\ ... r")

    /var/www/html/lib/private/AppFramework/App.php - line 159:

    OC\AppFramework\DependencyInjection\DIContainer->query("OCA\\Notes\ ... r")

    /var/www/html/lib/private/Route/Router.php - line 298:

    OC\AppFramework\App::main("OCA\\Notes\ ... r", "get", [ "OC\\AppFr ... "], [ "1087","notes.notes.get"])

    /var/www/html/lib/base.php - line 1047:

    OC\Route\Router->match("/apps/notes/notes/1087")

    /var/www/html/index.php - line 36:

    OC::handleRequest()

And

Error	notes	Error: Undefined constant OCP\Share\IShare::TYPE_SCIENCEMESH

    /var/www/html/custom_apps/notes/lib/Service/Note.php - line 109:

    OCA\Notes\Service\NoteUtil->getShareTypes([ "OC\\Files\\Node\\File"])

    /var/www/html/custom_apps/notes/lib/Controller/Helper.php - line 62:

    OCA\Notes\Service\Note->getData([ "etag","content"])

    /var/www/html/custom_apps/notes/lib/Controller/Helper.php - line 114:

    OCA\Notes\Controller\Helper->getNoteData([ "OCA\\Notes\\Service\\Note"], [ "etag","content"], [ "OCA\\Notes\\Db\\Meta",8676])

    <<closure>>

    OCA\Notes\Controller\Helper->OCA\Notes\Controller\{closure}("*** sensiti ... *")

    /var/www/html/custom_apps/notes/lib/Controller/Helper.php - line 113:

    array_map([ "Closure"], [ "*** sensi ... "])

    /var/www/html/custom_apps/notes/lib/Controller/NotesController.php - line 71:

    OCA\Notes\Controller\Helper->getNotesAndCategories(0, [ "etag","content"])

    /var/www/html/custom_apps/notes/lib/Service/Util.php - line 26:

    OCA\Notes\Controller\NotesController->OCA\Notes\Controller\{closure}("*** sensiti ... *")

    /var/www/html/custom_apps/notes/lib/Controller/Helper.php - line 140:

    OCA\Notes\Service\Util::retryIfLocked([ "Closure"])

    /var/www/html/custom_apps/notes/lib/Controller/NotesController.php - line 97:

    OCA\Notes\Controller\Helper->handleErrorResponse([ "Closure"])

    /var/www/html/lib/private/AppFramework/Http/Dispatcher.php - line 225:

    OCA\Notes\Controller\NotesController->index(0)

    /var/www/html/lib/private/AppFramework/Http/Dispatcher.php - line 133:

    OC\AppFramework\Http\Dispatcher->executeController([ "OCA\\Note ... "], "index")

    /var/www/html/lib/private/AppFramework/App.php - line 172:

    OC\AppFramework\Http\Dispatcher->dispatch([ "OCA\\Note ... "], "index")

    /var/www/html/lib/private/Route/Router.php - line 298:

    OC\AppFramework\App::main("OCA\\Notes\ ... r", "index", [ "OC\\AppFr ... "], [ "notes.notes.index"])

    /var/www/html/lib/base.php - line 1047:

    OC\Route\Router->match("/apps/notes/notes")

    /var/www/html/index.php - line 36:

    OC::handleRequest()

Screenshots

Server

Please complete the following information.

• Notes app version: 4.9.0
• Nextcloud version: 25.0.5
• OS: StartOS (based on Debian)
• Web server:
• PHP version:
• Database: Postgres

Nextcloud configuration:

``` If you have access to your command line run e.g.: sudo -u www-data php occ config:list system from within your Nextcloud installation folder ```

Client

Please complete the following information.

• Browser (incl. version):
• OS:

Log files

Add relevant parts of your nextcloud.log and/or your browser's JavaScript console here.

[MattDHill]

Duplicate of #1177