Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save when switching notes #300

Closed
BloodyIron opened this issue Mar 11, 2019 · 16 comments
Closed

Save when switching notes #300

BloodyIron opened this issue Mar 11, 2019 · 16 comments
Labels
feature: editor Related to generic parts of the editor, e.g. loading/saving notes needs info More details are needed in order to validate issue

Comments

@BloodyIron
Copy link

BloodyIron commented Mar 11, 2019

I'm a fast typer, so I can often switch from one note to another fast. Sometimes when I make adjustment to a note in the webGUI, then switch to another node, the changes I just made don't save.

Can we get it so when you switch to another note it immediately saves the previous note changes please?

Sometimes saving doesn't quite work 100% on android either, but not sure if that's the same issue or not.

Thanks! :D

@korelstar korelstar changed the title [Feature Adjustment] Save when switching notes Save when switching notes Mar 13, 2019
@korelstar
Copy link
Member

I can't reproduce this issue: even if I switch to another note before the last note was saved (I still see the star behind the note's title in the app navigation), the last note is saved some seconds later.

Could you please describe the exact steps to reproduce this? Please give also some hints about your environment (e.g. speed of your internet connection, the server and the client; browser version, operating system, Nextcloud version, Notes version, etc.).

The Android problem should be discussed in a separate issue in the Android app's repository.

@BloodyIron
Copy link
Author

This is on LAN through a reverse proxy, browser is Vivaldi, Ubuntu 18.10, NC 15.0.1, Notes version 2.5.1

Steps are identical as described above.

@korelstar
Copy link
Member

Please try if this also happens in (e.g.) Firefox.

@BloodyIron
Copy link
Author

It happens occasionally in Firefox. But it is not easy to reproduce, namely because I have to type and switch really fast to reproduce it. Something I do legitimately do from time to time. And it took multiple consecutive attempts to get it to happen again. (this is firefox btw, same behaviour as observed in Vivaldi).

Firefox 65.0.1 64-bit Ubuntu

@iSpeeX
Copy link

iSpeeX commented Apr 15, 2019

I don't know if I have the same case as you, but I can tell that's it's diffucult to me to see when a note is saved and it seems to be pretty slow.
Can you add a "save" button or "synchronize" button ?

@korelstar
Copy link
Member

@iSpeeX You can press CTRL+S in order to manually save the current note.

@iSpeeX
Copy link

iSpeeX commented Apr 15, 2019

Oh crap... I tried to use this "standard" shortcut, but everytime i use it, i get a pop-up to save the entire page in HTML.
Maybe it's due to opera (my browser), will try later ! Thank you very much

@BloodyIron
Copy link
Author

FYI sometimes when I hit ctrl+s my browser things I want to save the page, then brings up my OS "save as" kind of interface. But sometimes it properly triggers the notes save tooo.

The issue I was having isn't frequent, but I think it might be from rapid switching between notes that are saving, or trying to save.

@korelstar korelstar added the feature: editor Related to generic parts of the editor, e.g. loading/saving notes label May 24, 2019
@korelstar
Copy link
Member

@BloodyIron I've just released v3.0.0 which contains a complete rewrite of the JavaScript part. Please test again with this version and give some feedback.

@BloodyIron
Copy link
Author

@korelstar okay! :)

@korelstar
Copy link
Member

Any news on this? Did the issue occur again?

@korelstar korelstar added the needs info More details are needed in order to validate issue label Aug 20, 2019
@BloodyIron
Copy link
Author

At this point, I haven't observed the issue resurface. Thanks for the help! :D

@xxKeith20xx
Copy link

I've seen this occur in the past and just make sure to not leave a notes page open if I remember to. I think that causes some syncing quirks depending on how many devices it's open in?

@BloodyIron
Copy link
Author

Have you tried since the new release? Have you re-tested with that version? I have and for me, it doesn't happen.

if you could retest with the latest version, and reproduce the issue, I bet that'd be helpful to the dev.

I've seen this occur in the past and just make sure to not leave a notes page open if I remember to. I think that causes some syncing quirks depending on how many devices it's open in?

@xxKeith20xx
Copy link

@BloodyIron I haven't had any issues whatsoever on the latest version of Notes and Nextcloud 16.0.4

@korelstar
Copy link
Member

Great! Then, I'll close this issue. Thanks for your feedback :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: editor Related to generic parts of the editor, e.g. loading/saving notes needs info More details are needed in order to validate issue
Projects
None yet
Development

No branches or pull requests

4 participants