Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding to table cells #355

Closed
CodeAlDente opened this issue Aug 27, 2019 · 3 comments · Fixed by #362
Closed

Add padding to table cells #355

CodeAlDente opened this issue Aug 27, 2019 · 3 comments · Fixed by #362
Labels
design Related to the design or user experience enhancement New feature or request feature: Markdown-it Related to preview mode using Markdown-it
Milestone

Comments

@CodeAlDente
Copy link

CodeAlDente commented Aug 27, 2019

Is your feature request related to a problem? Please describe.
In reference to #115 tables are supported now. When I add them to a note and take a look at the preview, there is no padding inside the cells. This results in a difficult readability as you can not tell where the content of a cell starts and where it ends.

Input:

| First head   | Second head  | Third head   |
|--------------|--------------|--------------|
| ABC123456789 | DEF123456789 | GHI123456789 |
| JKL123456789 | MNO123456789 | PQR123456789 |
| STU123456789 | VWX123456789 | YZ123456789  |

Output:
1566896755-001

Describe the solution you'd like
Padding must be applied to the cells.

Describe alternatives you've considered
In addition to that it would be nice to apply font-weight: bold to thead to differ them from the tbody. Also the tables width should be set to 100% to make use of the whole space.

Additional context
See above.

@CodeAlDente CodeAlDente added needs discussion Need to clarify if and how we should implement this enhancement New feature or request labels Aug 27, 2019
@korelstar
Copy link
Member

Yes, we could adjust the style for the preview mode. How about that?

Screenshot

  • th is bold
  • th and td has 1em padding
  • table width is still auto, since 100% doesn't make sense in most cases

@CodeAlDente
Copy link
Author

Looks much better. What about 1.5em? Just to be sure.

@korelstar korelstar mentioned this issue Aug 28, 2019
3 tasks
@korelstar
Copy link
Member

I'm fine with that, see #362

@korelstar korelstar added this to the 3.0.2 milestone Aug 28, 2019
@korelstar korelstar added design Related to the design or user experience feature: Markdown-it Related to preview mode using Markdown-it and removed needs discussion Need to clarify if and how we should implement this labels Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to the design or user experience enhancement New feature or request feature: Markdown-it Related to preview mode using Markdown-it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants