public embed call notification api endpoint

[Cyrille37]

Steps to reproduce

1. create a "embed link" for a calendar
2. integrate the iframe in a web page
3. keep you browser logged in Nextcloud (don't logout nextcloud)
4. visite the wep page with the embeded calendar
5. look at the browser console for call to XHR GET https://theserver/ocs/v2.php/apps/notifications/api/v2/notifications

Expected behaviour

No call to notifications endpoint in a public embed.

Actual behaviour

Periodically call to notification endpoint (every 30 secondes).

There is no notification call if your browser is not logged in.

Calendar app

Calendar app version: 2.0.3

Client configuration

Browser: whatever

Server configuration

Nextcloud Version: 19.0.1

Browser log

XHR GET https://cloud.xxxx.coop/ocs/v2.php/apps/notifications/api/v2/notifications [HTTP/2 304 Not Modified 309ms]
...
...

[tcitworld]

Could we avoid loading the notifications script on @PublicPage ?

[Cyrille37]

I've changed the description: notification calls only happen when the browser is logged in Nextcloud.

[Cyrille37]

notification calls only happen when the browser is logged in Nextcloud.

With this new information, perhaps this issue is not a bug but a behavior ??
Perhaps we can close it ?

[Cyrille37]

More around:

Displaying the web page while logged in Nextcloud calls notification endpoint, and after logout Nextcloud, notification call is slowing down to 1 minute.

[Cyrille37]

Does not seem to be a bug, but a nice behavior if notification is accurate while showing a embeded calendar ... Don't know ...

[tcitworld]

@szaimen I'd say the issue lies in server, as server shouldn't include the script for notifications when the page is a @PublicPage.

[nickvergessen]

as server shouldn't include the script for notifications when the page is a @PublicPage.

So no notifications while being on Talk? xP

[tcitworld]

Oh, right, didn't know where this was hooked in.

[szaimen]

I must say that was a really fast fix 😅