Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic color adjustments should take place based on the selected theme color #104

Closed
j-ed opened this issue Dec 12, 2017 · 8 comments
Closed
Assignees
Labels

Comments

@j-ed
Copy link

j-ed commented Dec 12, 2017

As requested by @juliushaertl (nextcloud/server#7441 (comment)) I've created this issue.

Expected behavior

Depending on the selected theme color the notification alert color, and maybe others, should automatically be adjusted to be still visible.

Current behavior

No automatic color adjustments seems to take place at all.

Steps to reproduce

  1. Open the admin settings.

  2. Change the theming color to FF0000.
    20171210_nc_theming_color

  3. Check the notification symbol in the menu bar
    20171210_nc_theming_alert_color

  4. The notification alert is nearly invisible.

Better visibility could look like this:
20171210_nc_theming_alert_better_color

Environment

Server Configuration

OS: Linux 3.16.50
Web server: Apache2 2.4.29
Database: MariaDB 10.0.32
PHP version: 5.6.29
Nextcloud version: 12.0.4

Client Configuration

Browser: Mozilla Firefox 57.0.2
Operating system: Windows 7

@nickvergessen
Copy link
Member

Hmm we are not replacing anything on the fly, but I guess we can just add a 3rd version of the bell: white+red, black+red, white+nextcloud-blue

Just need to decide how we determinate that a color is too red.

@nickvergessen nickvergessen modified the milestone: Nextcloud 14 Jan 2, 2018
@j-ed
Copy link
Author

j-ed commented Jan 2, 2018

Although I'm not a developer I stumbled over similar problems years ago where someone has erroneously set e.g. the character color and the background color of an application to the same color 😄
Wouldn't make sense to implement a kind of automatic check as it is described here:
https://css-tricks.com/reverse-text-color-mix-blend-mode/

@juliusknorr
Copy link
Member

Do we actually need the red dot there, since we only show the icon if there are notifications available? @nextcloud/designers

@MorrisJobke
Copy link
Member

Do we actually need the red dot there, since we only show the icon if there are notifications available? @nextcloud/designers

The plan was to show it permanently: #2

@nickvergessen
Copy link
Member

nickvergessen commented Jan 3, 2018

We could then still do this with transparency, but I like the additional color, makes it a bit more 🎉

@MariusBluem
Copy link
Member

The plan was to show it permanently: #2

PR for showing it permanently is in: #107

@jancborchardt
Copy link
Member

Ok, so default to the lil red dot, and if the theming color is on the red spectrum, make the dot blue?

Can we do that with theming check and CSS/SVG magic @juliushaertl?

@juliusknorr
Copy link
Member

Should be fairly simple, if we migrate the notifications app to SCSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants