Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout broken with mentions and actions #387

Closed
nickvergessen opened this issue Jul 17, 2019 · 7 comments · Fixed by #388
Closed

Layout broken with mentions and actions #387

nickvergessen opened this issue Jul 17, 2019 · 7 comments · Fixed by #388

Comments

@nickvergessen
Copy link
Member

Regressions from #381 and #382 cc @juliushaertl @jancborchardt

Bildschirmfoto von 2019-07-17 12-31-00

User names are split over multiple lines

Bildschirmfoto von 2019-07-17 12-31-41

Action buttons don't stretch the notification body anymore and therefor overlap other notifications

@nickvergessen
Copy link
Member Author

Removing display: inline-flex; from #381 fixes the issue, so that is an option for 17, if no other solution was found.

@juliusknorr
Copy link
Member

Fix is in #388

@raimund-schluessler
Copy link
Member

Shouldn't this be fixed in NC 16.0.4 already? I still see this issue:
Screenshot-2019-8-28 Files - Nextcloud

@nickvergessen
Copy link
Member Author

I wondered the same after seeing it this week on 16.0.4
I faked the notifications on master and it looked okay there 🤔

@juliushaertl did we forget to backport something (I couldn't find anything missing) or do you have any other idea?

@raimund-schluessler
Copy link
Member

In stable16 the display: inline-flex; causing the problem is still there: https://github.com/nextcloud/notifications/blob/stable16/css/styles.scss#L132

@nickvergessen
Copy link
Member Author

Interesting
master: https://github.com/nextcloud/notifications/pull/388/files
automatic backport: https://github.com/nextcloud/notifications/pull/392/files

but at the same time, the code is not there in the diff around #392

Anyway thanks for the pointed, will remove the lines

@raimund-schluessler
Copy link
Member

Looks like #390 / #392 and #388 somehow collided!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants