[Bug]: Repair warning: Failed to delete folder: 'nextcloud.oc_photos_albums' doesn't exist on Upgrade

[AndyXheli]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Upggraded from NC 24.0.7 to NC 25.0.1

Steps to reproduce

Upggraded from NC 24.0.7 to NC 25.0.1

Expected behavior

Should not see this error\warning ?

Installation method

Community Manual installation with Archive

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 22.2.3 to 23.0.1)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

N/A

Nextcloud Signing status

No response

Nextcloud Logs

{"reqId":"JMMzCVhyvgd7i9pGc3ki","level":3,"time":"2022-11-03T09:05:13-05:00","remoteAddr":"6.8.6.4","user":"--","app":"no app in context","method":"GET","url":"/core/ajax/update.php?requesttoken=B43dbap5gNIIR%2BeODhAu9YSP3MSGNP%2FHwqIvgYqJP9I%3D%3AUvypD50BxupPEq6hWXgdu%2FD5lYLqbYb0ifd2wOzkebQ%3D","message":"Table \"oc_photos_collaborators\" has no primary key and therefor will not behave sane in clustered setups. This will throw an exception and not be installable in a future version of Nextcloud.","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36","version":"24.0.7.1","data":[],"id":"6363cc2b0d246"}
{"reqId":"JMMzCVhyvgd7i9pGc3ki","level":2,"time":"2022-11-03T09:05:12-05:00","remoteAddr":"6.8.6.4","user":"--","app":"updater","method":"GET","url":"/core/ajax/update.php?requesttoken=B43dbap5gNIIR%2BeODhAu9YSP3MSGNP%2FHwqIvgYqJP9I%3D%3AUvypD50BxupPEq6hWXgdu%2FD5lYLqbYb0ifd2wOzkebQ%3D","message":"OC\\Repair\\Events\\RepairWarningEvent: Repair warning: Failed to delete folder: \"images\", error: An exception occurred while executing a query: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'nextcloud.oc_photos_albums' doesn't exist","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36","version":"24.0.7.1","data":{"app":"updater"},"id":"6363cc2b0d36e"}
{"reqId":"JMMzCVhyvgd7i9pGc3ki","level":2,"time":"2022-11-03T09:05:12-05:00","remoteAddr":"6.8.6.4","user":"--","app":"updater","method":"GET","url":"/core/ajax/update.php?requesttoken=B43dbap5gNIIR%2BeODhAu9YSP3MSGNP%2FHwqIvgYqJP9I%3D%3AUvypD50BxupPEq6hWXgdu%2FD5lYLqbYb0ifd2wOzkebQ%3D","message":"OC\\Repair\\Events\\RepairWarningEvent: Repair warning: Failed to delete folder: \"12\", error: An exception occurred while executing a query: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'nextcloud.oc_photos_albums' doesn't exist","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36","version":"24.0.7.1","data":{"app":"updater"},"id":"6363cc2b0d38f"}

Additional info

Might have something to do with this nextcloud/server#34620

Repair step: Initialize migration of background images from dashboard to theming app

Repair step: Cleanup old theming cache

Repair warning: Failed to delete folder: "12", error: An exception occurred while executing a query: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'nextcloud.oc_photos_albums' doesn't exist

[1 / 2]: Cleanup old theming cache

Repair warning: Failed to delete folder: "images", error: An exception occurred while executing a query: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'nextcloud.oc_photos_albums' doesn't exist

[2 / 2]: Cleanup old theming cache

[2 / 2]: Cleanup old theming cache

[szaimen]

This is probably caused by https://github.com/nextcloud/server/pull/34620/files but I fail to understand why it does that. Cc @artonge @Pytal on this

[szaimen]

@AndyXheli @mnalis was this the webupdater oder cli updater?

[AndyXheli]

Hi @szaimen web updater for me

[mnalis]

also web updater for me @szaimen

[lookup82]

@AndyXheli @mnalis was this the webupdater oder cli updater?

cli updater for me

[Pytal]

The repair step nextcloud/server#34620 in server only touches the filesystem not the database so this seems related to the oc_photos_albums table added to the photos app in 10f44aa#diff-6586891eb9b8c0148352d6d67d8b0ddb9a143a05200e47a61e2a3d75ad3593e4

@icewind1991 and @artonge may know more?

[mreho]

Hi,

I used the CLI updater, same warning.

Repair warning: Failed to delete folder: "21", error: An exception occurred while executing a query: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'nextcloud.oc_photos_albums' doesn't exist

[szaimen]

Please try again with 25.0.2