Fix new album form layout #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
ShGKme
requested review from
susnux,
JuliaKirschenheuter,
artonge,
Pytal and
szaimen
susnux
approved these changes
Oct 21, 2023
|
Just fix the node CI :) |
Would you believe if I say, I did npm ci, npm run build, git status is clear and node is 20 with npm 9 🙈 |
JuliaKirschenheuter
approved these changes
Oct 23, 2023
- Remove incorrect `<label>` - Set icon size 20px - Fix buttons margin Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/new-album-layout
branch
from
6393bd6
to
7562a46
Compare
|
Just rebased and re-compiled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of https://github.com/nextcloud/andy/issues/5
<label>wrapper<NcTextField>'sicon feature instead of separated iconaria-label-s. Buttons with texts should not have aria-label that is different from the button text.