Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.1.4.11/4.2 - Media files marked as favorites using stars - Depending on the background, the stars do not meet the contrast requirements for graphical informative elements (1) #2159

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 2 comments · Fixed by #2190
Closed

[BITV] 9.1.4.11/4.2 - Media files marked as favorites using stars - Depending on the background, the stars do not meet the contrast requirements for graphical informative elements (1) #2159

JuliaKirschenheuter opened this issue Nov 29, 2023 · 2 comments · Fixed by #2190
Assignees
@susnux
Labels
2. developing Work in progress a11y28checked needed for a11y accessibility backport-request Pending backport by the backport-bot bug Something isn't working

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 29, 2023 •
edited
Loading

as the contrast ratio with the background is below 3:1. It is recommended to place these elements outside of images.

image

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3dbfb7615a-v4-n2
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title [BITV] 9.1.4.11/4.2 - Media files marked as favorites using stars - Depending on the background, the stars do not meet the contrast requirements for graphical informative elements, as the contrast ratio with the background is below 3:1. It is recommended to place these elements outside of images. (1) [BITV] 9.1.4.11/4.2 - Media files marked as favorites using stars - Depending on the background, the stars do not meet the contrast requirements for graphical informative elements (1) Nov 29, 2023
@susnux susnux transferred this issue from nextcloud/server Nov 30, 2023
@susnux
Copy link
Contributor

susnux commented Nov 30, 2023

The color needs to be adjusted, see server for the current color used (on files or the weather widget). The correct icon is also provided as css class.

@susnux susnux self-assigned this Nov 30, 2023
@susnux susnux added 2. developing Work in progress bug Something isn't working and removed 1. to develop Accepted and waiting to be taken care of labels Dec 12, 2023
@susnux susnux mentioned this issue Dec 12, 2023
Merged
@szaimen szaimen mentioned this issue Dec 13, 2023
Closed
@JuliaKirschenheuter
Copy link
Contributor Author

@susnux could you please create a backport to stable28?

@JuliaKirschenheuter JuliaKirschenheuter added the backport-request Pending backport by the backport-bot label Dec 14, 2023
@szaimen szaimen added the a11y28checked needed for a11y label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
2. developing Work in progress a11y28checked needed for a11y accessibility backport-request Pending backport by the backport-bot bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Adjust favorite icon to be accessible nextcloud/photos
3 participants
@susnux @JuliaKirschenheuter @szaimen