Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SizeMetadataProvider to core? #2243

Open
SystemKeeper opened this issue Jan 9, 2024 · 3 comments
Open

Move SizeMetadataProvider to core? #2243

SystemKeeper opened this issue Jan 9, 2024 · 3 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request

Comments

@SystemKeeper
Copy link

Is your feature request related to a problem? Please describe.
When available, we are using the size metadata in Talk to correctly adjust the space needed for a file preview, before we download that preview. I was a bit confused, when I did not get size information for a gif file, but this is disabled in the photos app on purpose, because it’s not used for photos usually.

Describe the solution you'd like
I am wondering if it makes sense to move the SizeMetadataProvider (https://github.com/nextcloud/photos/blob/master/lib/Listener/SizeMetadataProvider.php) to server, instead of having it in the photos app, similar to the blurhash generation being in server as well (nextcloud/server#41044)

Describe alternatives you've considered
Either enable gif support in photos (or even just for the size provider) or just live with the fact that we don’t get size metadata for gifs.

@SystemKeeper SystemKeeper added enhancement New feature or request 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 9, 2024
@ArtificialOwl
Copy link
Member

@artonge ?

@artonge
Copy link
Collaborator

artonge commented Jan 10, 2024

Could make sense, I did not expect such use case

@SystemKeeper
Copy link
Author

SystemKeeper commented Jan 10, 2024

I did not expect such use case

Sorry about that 😂
I think when using the blurhash it makes sense to also know the size of the image, to correctly size the blurhash preview (or at least know orientation of the image)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants