Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Shared albums" does not show albums you shared with others #299

Closed
strugee opened this issue Apr 20, 2020 · 5 comments · Fixed by #495
Closed

"Shared albums" does not show albums you shared with others #299

strugee opened this issue Apr 20, 2020 · 5 comments · Fixed by #495
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request

Comments

@strugee
Copy link
Member

strugee commented Apr 20, 2020

Is your feature request related to a problem? Please describe.

I have a few folders shared that I expected to show up in the "Shared albums" tab. I actually thought Photos was buggy until I happened to read in another bug that it's only albums that other people have shared with you. We should rename it to avoid this confusion.

Describe the solution you'd like

"Shared with me" seems like a good description.

Describe alternatives you've considered

"Albums shared with me" maybe? It's a little wordy though. Or maybe "Shared with you"? Let us bikeshed

Additional context

I'll probably try and poke at this and submit a PR if I get the time but someone else should feel free to get to it before me ;)

@strugee strugee added enhancement New feature or request 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Apr 20, 2020
@skjnldsv
Copy link
Member

cc @jancborchardt

@jancborchardt
Copy link
Member

Not sure I understand. "Shared albums" should of course also show albums that you shared eith others, just like the "Shared" section in Files.

@strugee
Copy link
Member Author

strugee commented Apr 20, 2020

Right, that makes sense to me too, but currently it doesn't do that. I figured this rename would be better to alleviate confusion in the short term until that's implemented. I actually don't know if there's a bug on file for it; I can check later when I'm not on mobile :-)

@jancborchardt jancborchardt changed the title Rename "Shared albums" to "Albums shared with me" "Shared albums" does not show albums you shared with others Apr 20, 2020
@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Apr 20, 2020
@t2d

This comment has been minimized.

@jancborchardt

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants