Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albums URL bug in subfolders, %2F instead of / #327

Closed
JonOfUs opened this issue May 4, 2020 · 13 comments · Fixed by #514
Closed

Albums URL bug in subfolders, %2F instead of / #327

JonOfUs opened this issue May 4, 2020 · 13 comments · Fixed by #514
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working medium Medium priority

Comments

@JonOfUs
Copy link

JonOfUs commented May 4, 2020

When you are using the 'albums' feature (index.php/apps/photos/albums/) and clicking through folder hierarchies, sometimes the URL changes wrongly when using Firefox (75.0 on Linux Mint).
When you go to a subfolder of any folder, the URL changes to e.g. "index.php/apps/photos/albums/MyPictures%2FGreece" instead of "index.php/apps/photos/albums/MyPictures/Greece", the / is wrongly displayed as the html-code %2F. When you reload while the browser in is such a subfolder, apache just passes you a 404-error.
When going to even deeper subfolders, the error continues, / is still displayed as %2F which results in 404-errors when reloading.

Screenshot from 2020-05-04 20-43-14

I am not skilled enough in php and in the NextCloud backend to pass a suitable correction for the app, so it would be nice, if anybody who feels skilled enough, could fix this little bug.

Greetings, John

@SimJoSt
Copy link

SimJoSt commented May 16, 2020

I can confirm this issue with Chrome as well.

@SimJoSt SimJoSt added the bug Something isn't working label May 16, 2020
@skjnldsv
Copy link
Member

Are you all using apache?

@skjnldsv skjnldsv added 0. Needs triage Pending approval or rejection. This issue is pending approval. needs info Not enough information provided labels Jul 13, 2020
@JonOfUs
Copy link
Author

JonOfUs commented Jul 13, 2020

Yes, the problem only occurs when using Apache.
When using Nginx, forward-slash still is replaced with %2F sometimes, but reloading the page works nevertheless without problems.
So this could just be an Apache error or even just a wrong web-server configuration.
Nevertheless, the fact that forward-slash sometimes is displayed with %2F cannot be intentional.

@skjnldsv
Copy link
Member

skjnldsv commented Jul 14, 2020

I guess this should be fix in a higher level.
Nevertheless I suggest you update your apache config. It seems you're not even supporting the url rewriting :)

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of medium Medium priority and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. needs info Not enough information provided labels Jul 14, 2020
@darmbrust
Copy link

Is URL rewriting supposed to be enabled for a nextcloud deployment? If so, it would be nice if Nextcloud told us it was off / improperly configured on the admin page, like it does for so many other config issues.

@mblo
Copy link

mblo commented Sep 9, 2020

Same problem here, with Safari/Edge tested on 19.0.2 (Photos on 1.1.0). My setup runs in a subfolder ("domain.com/sub/..nextcloud") and uses the nc default htaccess rewrite rules.

Any further information required?

@bars-suk

This comment has been minimized.

@tborychowski

This comment has been minimized.

@skjnldsv
Copy link
Member

Is URL rewriting supposed to be enabled for a nextcloud deployment? If so, it would be nice if Nextcloud told us it was off / improperly configured on the admin page, like it does for so many other config issues.

PR welcome :)
But it's in the documentation yeah https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#additional-apache-configurations

@darmbrust
Copy link

Are you referring to the https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#pretty-urls ?

I have mod_rewrite enabled on my server. And all of the other recommended ones as well. This bug exists with all of those enabled on apache, unless there is a config I need to set that I missed...

@bars-suk
Copy link

Nextcloud 19.0.4
Версия сервера: Apache / 2.4.38 (Debian)

Проблема не устранена !!

The problem occurs with a subfolder, with one folder there are no problems.

@skjnldsv
Copy link
Member

@Mikescops this is the issue I was telling you about :)

@Mikescops
Copy link
Member

Yep, I know, should find something because it's kinda annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working medium Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants