Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖼️ Sorting pictures by taken date instead of modification date #87

Closed
Tracked by #40676
tillwf opened this issue Jan 6, 2020 · 42 comments · Fixed by #2125
Closed
Tracked by #40676

🖼️ Sorting pictures by taken date instead of modification date #87

tillwf opened this issue Jan 6, 2020 · 42 comments · Fixed by #2125
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request feature: timeline Related to the timeline section high High priority technical debt Technical issue
Milestone

Comments

@tillwf
Copy link

tillwf commented Jan 6, 2020

For travel albums or for any event, pictures modification time does not reflect the event timeline.

It happens a lot that pictures are modify (cropping, enhancements, etc.), and changing their orders does not help readability.

Could the creation date be the default info used ?

@skjnldsv skjnldsv added the 0. Needs triage Pending approval or rejection. This issue is pending approval. label Jan 6, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Jan 6, 2020

It would be a nice enhancement.
But we currently do not store the taken date

cc @rullzer

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 7, 2020
@skjnldsv skjnldsv changed the title Sorting pictures by modification time makes albums incoherent Sorting pictures by taken date instead of modification date Jan 7, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Jan 7, 2020

cc @jancborchardt if it make sense

@jancborchardt
Copy link
Member

Yep, very good point – for photos it absolutely makes sense to sort by taken date, exactly for the reasons @tillwf mentioned. :)

@jancborchardt jancborchardt added the feature: timeline Related to the timeline section label Jan 7, 2020
@skjnldsv skjnldsv added this to the 1.1.0 milestone Jan 7, 2020
@tillwf
Copy link
Author

tillwf commented Jan 9, 2020

Could it simply be sorted by the name as a start ? With current cameras naming convention, the filename reflects the creation date order.

@skjnldsv
Copy link
Member

skjnldsv commented Jan 9, 2020

I'd rather have modification date (like all mobile galleries work) than name

@jancborchardt jancborchardt added the high High priority label Jan 12, 2020
@jancborchardt
Copy link
Member

Could it simply be sorted by the name as a start ? With current cameras naming convention, the filename reflects the creation date order.

This would break down as soon as you get photos from a second camera or from friends, or the numbering of your own camera wraps – so the current way is better for now. :)

@tillwf
Copy link
Author

tillwf commented Jan 12, 2020

@jancborchardt You're right. However, it is not better now, because currently the order is completely random as I transfer my picture using scp. That is why I was saying "as a start". I prefer to have 2 sets of photos ordered than nothing coherent.

@frieck
Copy link

frieck commented Jul 10, 2020

Guys, can't we just change this line

'lastmod' => $node->getMTime(),

to use $node->getCreationTime()?
That makes picture be displayed in a more logical order....

@skjnldsv
Copy link
Member

@frieck this suggest is about the taken date, not the creation date of the file.
So we'd need exif support

@frieck
Copy link

frieck commented Jul 13, 2020

Hi @skjnldsv,
For me all photos are being displayed in an incorrect order as they all have been modified sometime.
So changing that line that I mentioned helped me to fix part of the problem, I understand that a File can have a creation date different from the photo that it represents, but that seems to be more uncommon than having a modification date and everything listed by that modification date.

@skjnldsv
Copy link
Member

skjnldsv commented Jul 14, 2020

@frieck not arguing with your specific issue :)
It fits some people use, but also not for others. Just reminding that this issue is about the photo taken date, not creation date.

Could the creation date be the default info used ?

Nonetheless, I just notice this line on the main post, which make this confusing 😛
@jancborchardt shall we use creation date by default instead of last modified?

@rullzer rullzer modified the milestones: Nextcloud 20, Nextcloud 21 Oct 3, 2020
@jancborchardt
Copy link
Member

@jancborchardt shall we use creation date by default instead of last modified?

Yep! :)

@da-anda
Copy link

da-anda commented Oct 16, 2020

creation date of the file is better than the mtime, but EXIF data would ofc be best. Unfortunately, creation date (filesystem level) is also of no use if you use the NC app to sync your pictures from the phone, since all files end up with a creation date of the time of the upload :(

@skjnldsv skjnldsv added the good first issue Good for newcomers label Oct 16, 2020
@Zaijo
Copy link

Zaijo commented Feb 8, 2021

BTW, there's this application https://github.com/gino0631/nextcloud-metadata which can already extract metadata of many formats. Is there a way to use that? @Mikescops @skjnldsv ?

@gipadm
Copy link

gipadm commented Feb 12, 2021

@Zaijo I am also interested in helping out with this one. Let me know.

@Zaijo
Copy link

Zaijo commented Feb 16, 2021

I'm sorry guys but in between I found Photoprism https://docs.photoprism.org/ which I now use alongside with Nextcloud and this EXIF way for Nextcloud Photos seems to have a veeeery long path before it's usable for me.

@johannestophoj
Copy link

johannestophoj commented Feb 16, 2021

@Zaijo , did you use some guide to install photoprism and set it up with nextcloud? This sync-option looks like it duplicates the image data (?) https://docs.photoprism.org/user-guide/settings/sync/

@Zaijo
Copy link

Zaijo commented Feb 16, 2021

Let's move to e.g. Twitter with that so we don't spam this thread. https://twitter.com/zaj0

@skjnldsv
Copy link
Member

BTW, there's this application gino0631/nextcloud-metadata which can already extract metadata of many formats. Is there a way to use that? @Mikescops @skjnldsv ?

Like mentioned on this thread and others multiple time, this require metadata to be merged and shipper into nextcloud server, available through dav and have a dedicated API for other apps.
Then it would be a few lines of code for the Photos app.

@Joshua2504

This comment has been minimized.

@jcclerval
Copy link

I reckon it will take some time before it is properly managed server-side. How about some partial temporary feature using PHP built-in EXIF support ? Something similar at what I have written above, but better and at the right place ?

@skjnldsv
Copy link
Member

No, it must be done right or none at all. Temporary hackish features are what got us in lots of trouble in lots of areas. And then no one maintains it, and it suddenly becomes the bottleneck for any desired changes. 😖

Locking this thread, nothing more productive seems to be added, you are all free to start working on this and I will help you implement it if you do. 👍

@nextcloud nextcloud locked as off-topic and limited conversation to collaborators Mar 29, 2021
@jakobroehrl
Copy link
Contributor

@marcelklehr
How hard is it to fix this issues when nextcloud/server#30366 will be merged?

@marcelklehr
Copy link
Member

Shouldn't be too hard, IMHO. One problem is that file creation dates are a relatively recent addition to the linux family so may not always be available...

@jancborchardt jancborchardt removed the good first issue Good for newcomers label Mar 21, 2023
@jancborchardt
Copy link
Member

@artonge what do you think about this one regarding feasibility? Would it need EXIF data to be saved or something else as prerequisite?

@artonge
Copy link
Collaborator

artonge commented Mar 21, 2023

This would need the EXIF data to be saved in the oc_file_metadata table. Easy. But this would also need to be able to order files with on a metadata entry. Harder as there is no logic for that yet. I did not event looked at it, so not even sure that is possible, but I hope it is.

@jancborchardt
Copy link
Member

What’s the current state or feasibility regarding this now that we have the data in the metadata table (right?) – @artonge?

@szaimen
Copy link
Contributor

szaimen commented Aug 15, 2023

Looks like this would need to be first done by the desktop and other client apps?
See nextcloud/server#30366 (comment)

@jancborchardt
Copy link
Member

cc @tobiasKaminsky also for the client part as mentioned by @szaimen.

@tobiasKaminsky
Copy link
Member

This would need the EXIF data to be saved in the oc_file_metadata table.

This is only on server.
On clients there is no reliable way to check/send creation date.

@artonge
Copy link
Collaborator

artonge commented Aug 16, 2023

What’s the current state or feasibility regarding this now that we have the data in the metadata table (right?) – @artonge?

I do not think that we have the data yet.

@szaimen
Copy link
Contributor

szaimen commented Aug 16, 2023

So I guess we would need to extract the information on server and store it in the metadata table first?

@szaimen szaimen added the technical debt Technical issue label Aug 16, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Aug 30, 2023
@AndyScherzinger AndyScherzinger changed the title Sorting pictures by taken date instead of modification date 🖼️ Sorting pictures by taken date instead of modification date Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request feature: timeline Related to the timeline section high High priority technical debt Technical issue
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.