Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect format of the day number #1711

Closed
FPasca opened this issue Jun 8, 2021 · 8 comments · Fixed by #1748
Closed

incorrect format of the day number #1711

FPasca opened this issue Jun 8, 2021 · 8 comments · Fixed by #1748
Labels
Milestone

Comments

@FPasca
Copy link

FPasca commented Jun 8, 2021

What is going wrong?

In Italian language the day number of month is for example 9, writing 9° is a mistake.
This makes the application unusable for professional purposes.
This error was already present in version 1.8.3.
Thanks for beautifull app.
screenshot

@FPasca
Copy link
Author

FPasca commented Jun 9, 2021

This is the correct format:
screenshot1
Could you fix date format, please :) or tell me where to find code for that?
Thank you!

@dartcafe
Copy link
Collaborator

You can find the formatting here, but the layout is defined from moment.

return {
from: {
month: from.format('MMM [ \']YY'),
day: from.format('Do'),
dow: from.format('ddd'),
time: from.format('LT'),
date: from.format('ll'),
dateTime: from.format('llll'),
utc: moment(from).utc().format('llll'),
},
to: {
month: toModified.format('MMM'),
day: toModified.format('D'),
dow: toModified.format('ddd'),
time: to.format('LT'),
date: toModified.format('ll'),
dateTime: to.format('llll'),
utc: moment(to).utc().format('llll'),
sameDay: from.format('L') === toModified.format('L'),
},
dayLong: dayLongEvent,
}

@FPasca
Copy link
Author

FPasca commented Jun 12, 2021

OK, Thanks!

@FPasca
Copy link
Author

FPasca commented Jun 14, 2021

Changed from:

month: from.format('MMM [ \']YY'),
day: from.format('Do'),

to:

month: from.format('MMM YYYY'),
day: from.format('D')

now date is show as expected.
Thanks you very much!

@dartcafe
Copy link
Collaborator

I am planning to switch day: from.format('Do'), to day: from.format('D'), in the next release, but still prefer the shorter display of the year.

@FPasca
Copy link
Author

FPasca commented Jun 15, 2021

Right, but I'm afraid that users may confuse the short year with the day. At least until 2031. :D
I have had users who do not notice the horizontal scroll bar :D
I'll do some tests by removing the year or putting day on top and month and short year below.

@FPasca
Copy link
Author

FPasca commented Jun 15, 2021

This is the layout I like, it seems like a good compromise between short year visualization and does not confuse the users.
I think
Screen2

Copy link

github-actions bot commented Jun 3, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants