Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Nextcloud 28 #591

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Compatibility with Nextcloud 28 #591

merged 4 commits into from
Dec 21, 2023

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Nov 12, 2023

Closes #599

@tcitworld tcitworld self-assigned this Nov 12, 2023
@tcitworld tcitworld force-pushed the 28-compat branch 2 times, most recently from 15dc167 to d13501e Compare December 19, 2023 15:13
@tcitworld
Copy link
Member Author

/compile fixup /

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments apply to files with the same changes 😅

composer.json Outdated Show resolved Hide resolved
src/AdminSettings.vue Outdated Show resolved Hide resolved
templates/admin.php Outdated Show resolved Hide resolved
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the 28-compat branch 3 times, most recently from 4acd362 to f916b18 Compare December 21, 2023 08:58
@tcitworld
Copy link
Member Author

/compile fixup /

Mostly remove checks from lower NC versions and benefit from PHP 8's contructor property promotion

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld merged commit 959773c into master Dec 21, 2023
22 of 31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the 28-compat branch December 21, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version for NC28
3 participants