-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error loading related resources in 1:1 chat on cloud.nextcloud.com #62
Comments
@Pytal bug in the vue lib or the related resources app? |
Hmm I think the actual issue is that guests are not allowed to use the related_resources app. So maybe we should define a initial state that apps that want to integrate can check for? |
Can reproduce with a guest in the conversation Wouldn't it be better to handle this with a guest case in related_resources/lib/RelatedResourceProviders/TalkRelatedResourceProvider.php Lines 180 to 195 in d584d68
InvalidRecipientException which bubbles up and returns an empty array response which automatically hides the panel @ArtificialOwl @nickvergessen ?
|
totally forgot to report this issue or error if app is not available/enabled. My guess would be to just log in console on issue maybe ? |
In this context Talk is enabled and if Related resources is disabled it is already being handled gracefully in the panel component logic, which "app" being disabled are you referring to @ArtificialOwl? |
Also, we should still ignore error on the front-end as the RelatedResources app might be disable/not_available to the current user |
Would it make sense to catch this exception (or a new InvalidRecipientException) related_resources/lib/RelatedResourceProviders/TalkRelatedResourceProvider.php Lines 193 to 195 in 372e227
higher up and return an empty array to the client to resolve the error? |
#65 will ignore this kind of entries and process with the rest of the vailable entities |
If you mean for guests then I tested it and it doesn't show the "Shared items" tab anyways so it won't even try to load it |
fixed in 1.0.1 |
@ArtificialOwl is this version already runnng on c.nc.c? If yes, I still get the error message |
@ArtificialOwl @Pytal I still can see the error message in my 1:1 chats on cloud.nextcloud.com. Should I reopen the issue? Do you need more logs or anything? |
How to use GitHub
Steps to reproduce
Expected behaviour
No error message
Actual behaviour
Error message "error loading related resources" (because of 0 KB quota on that instance??)
Talk app
Talk app version: current version on cloud.nextcloud.com
Custom Signaling server configured: ùnknown
Custom TURN server configured: unknown
Custom STUN server configured: unknown
Browser
Microphone available: unrelated
Camera available: unrelated
Operating system: independent
Browser name: Firefox
Browser version: 102.3esr
Browser log
The text was updated successfully, but these errors were encountered: