Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded Viewer code #3728

Closed
elzody opened this issue Jun 3, 2024 · 0 comments · Fixed by #3727
Closed

Remove unneeded Viewer code #3728

elzody opened this issue Jun 3, 2024 · 0 comments · Fixed by #3727
Assignees
@elzody
Labels
3. to review Ready to be reviewed javascript Pull requests that update Javascript code

Comments

@elzody
Copy link
Contributor

elzody commented Jun 3, 2024

After the updated file action to open a PDF using richdocuments instead of the files_pdfviewer, some old code was still left behind which is not needed anymore since the PR was merged. It should probably be removed now.

PR which was merged: #3645
@elzody elzody added 3. to review Ready to be reviewed javascript Pull requests that update Javascript code labels Jun 3, 2024
@elzody elzody self-assigned this Jun 3, 2024
@elzody elzody mentioned this issue Jun 3, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jun 4, 2024
@elzody elzody moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Office team Jun 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elzody elzody

Labels
3. to review Ready to be reviewed javascript Pull requests that update Javascript code
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove legacy Viewer code nextcloud/richdocuments
1 participant
@elzody