Merge pull request #31876 from nextcloud/bugfix/noid/fix-getCurrentApp-from-cli

Fix \OC_App::getCurrentApp() when being called from CLI or phpunit

Author: PVince81

lib/private/legacy/OC_App.php

@@ -629,11 +629,21 @@ public static function getSettingsNavigation(): array {
 	 * @return string
 	 */
 	public static function getCurrentApp(): string {
+		if (\OC::$CLI) {
+			return '';
+		}
+
 		$request = \OC::$server->getRequest();
 		$script = substr($request->getScriptName(), strlen(OC::$WEBROOT) + 1);
 		$topFolder = substr($script, 0, strpos($script, '/') ?: 0);
 		if (empty($topFolder)) {
-			$path_info = $request->getPathInfo();
+			try {
+				$path_info = $request->getPathInfo();
+			} catch (Exception $e) {
+				// Can happen from unit tests because the script name is `./vendor/bin/phpunit` or something a like then.
+				\OC::$server->get(LoggerInterface::class)->error('Failed to detect current app from script path', ['exception' => $e]);
+				return '';
+			}
 			if ($path_info) {
 				$topFolder = substr($path_info, 1, strpos($path_info, '/', 1) - 1);
 			}