fixup! perf(external-sharing): Port to Entity and SnowflakeId

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

Author: CarlSchwan

apps/files_sharing/lib/External/ExternalShare.php

@@ -40,7 +40,7 @@
  * @method void setUser(string $user)
  * @method string getMountpoint()
  * @method string getMountpointHash()
- * @method void setMountPointHash(string $mountPointHash)
+ * @method void setMountpointHash(string $mountPointHash)
  * @method int getAccepted()
  * @method void setAccepted(int $accepted)
  *
@@ -106,7 +106,7 @@ public function jsonSerialize(): array {
 			'owner' => $this->getOwner(),
 			'user' => $this->getUser(),
 			'mountpoint' => $this->getMountpoint(),
-			'accepted' => $this->getAccepted(),
+			'accepted' => $this->getAccepted() ? true : false,
 
 			// Added later on
 			'file_id' => null,

apps/files_sharing/lib/External/Manager.php

@@ -80,7 +80,7 @@ public function addShare(ExternalShare $shareExternal, IUser|IGroup|null $userOr
 			// mount point name will be generated when accepting the share,
 			// using the original share item name.
 			$tmpMountPointName = '{{TemporaryMountPointName#' . $shareExternal->getName() . '}}';
-			$shareExternal->setMountPoint($tmpMountPointName);
+			$shareExternal->setMountpoint($tmpMountPointName);
 			$shareExternal->setUserOrGroup($userOrGroup);
 
 			$i = 1;
@@ -90,7 +90,7 @@ public function addShare(ExternalShare $shareExternal, IUser|IGroup|null $userOr
 					break;
 				} catch (Exception $e) {
 					if ($e->getReason() === Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
-						$shareExternal->setMountPoint($tmpMountPointName . '-' . $i);
+						$shareExternal->setMountpoint($tmpMountPointName . '-' . $i);
 						$i++;
 					} else {
 						throw $e;
@@ -107,7 +107,7 @@ public function addShare(ExternalShare $shareExternal, IUser|IGroup|null $userOr
 		$mountPoint = $userFolder->getNonExistingName($shareExternal->getName());
 
 		$mountPoint = Filesystem::normalizePath('/' . $mountPoint);
-		$shareExternal->setMountPoint($mountPoint);
+		$shareExternal->setMountpoint($mountPoint);
 		$shareExternal->setUserOrGroup($user);
 		$this->externalShareMapper->insert($shareExternal);
 

build/integration/features/bootstrap/Sharing.php

@@ -524,7 +524,7 @@ public function checkShareFields($body) {
 					$value = str_replace('LOCAL', substr($this->localBaseUrl, 0, -4), $value);
 				}
 				if (!$this->isFieldInResponse($field, $value)) {
-					Assert::fail("$field" . " doesn't have value " . "$value" . " but has value " . $this->getFieldValueInResponse($field));
+					Assert::fail("$field" . " doesn't have value " . "$value" . ' but has value ' . $this->getFieldValueInResponse($field));
 				}
 			}
 		}