Skip to content

Commit 3808f0c

Browse files
committed
Add void return types to callables
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
1 parent ad4193b commit 3808f0c

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

core/Command/Upgrade.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
105105
$dispatcher = \OC::$server->get(IEventDispatcher::class);
106106
$progress = new ProgressBar($output);
107107
$progress->setFormat(" %message%\n %current%/%max% [%bar%] %percent:3s%%");
108-
$listener = function (MigratorExecuteSqlEvent $event) use ($progress, $output) {
108+
$listener = function (MigratorExecuteSqlEvent $event) use ($progress, $output): void {
109109
$message = $event->getSql();
110110
if (OutputInterface::VERBOSITY_NORMAL < $output->getVerbosity()) {
111111
$output->writeln(' Executing SQL ' . $message);
@@ -126,7 +126,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
126126
}
127127
}
128128
};
129-
$repairListener = function (Event $event) use ($progress, $output) {
129+
$repairListener = function (Event $event) use ($progress, $output): void {
130130
if ($event instanceof RepairStartEvent) {
131131
$progress->setMessage('Starting ...');
132132
$output->writeln($event->getCurrentStepName());

core/ajax/update.php

+6-3
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,12 @@ public function handleRepairFeedback(Event $event): void {
121121

122122
/** @var IEventDispatcher $dispatcher */
123123
$dispatcher = \OC::$server->get(IEventDispatcher::class);
124-
$dispatcher->addListener(MigratorExecuteSqlEvent::class, function (MigratorExecuteSqlEvent $event) use ($eventSource, $l) {
125-
$eventSource->send('success', $l->t('[%d / %d]: %s', [$event->getCurrentStep(), $event->getMaxStep(), $event->getSql()]));
126-
});
124+
$dispatcher->addListener(
125+
MigratorExecuteSqlEvent::class,
126+
function (MigratorExecuteSqlEvent $event) use ($eventSource, $l): void {
127+
$eventSource->send('success', $l->t('[%d / %d]: %s', [$event->getCurrentStep(), $event->getMaxStep(), $event->getSql()]));
128+
}
129+
);
127130
$feedBack = new FeedBackHandler($eventSource, $l);
128131
$dispatcher->addListener(RepairStartEvent::class, [$feedBack, 'handleRepairFeedback']);
129132
$dispatcher->addListener(RepairAdvanceEvent::class, [$feedBack, 'handleRepairFeedback']);

lib/private/Updater.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -447,12 +447,12 @@ private function logAllEvents(): void {
447447
$dispatcher = \OC::$server->get(IEventDispatcher::class);
448448
$dispatcher->addListener(
449449
MigratorExecuteSqlEvent::class,
450-
function (MigratorExecuteSqlEvent $event) use ($log) {
450+
function (MigratorExecuteSqlEvent $event) use ($log): void {
451451
$log->info(get_class($event).': ' . $event->getSql() . ' (' . $event->getCurrentStep() . ' of ' . $event->getMaxStep() . ')', ['app' => 'updater']);
452452
}
453453
);
454454

455-
$repairListener = function (Event $event) use ($log) {
455+
$repairListener = function (Event $event) use ($log): void {
456456
if ($event instanceof RepairStartEvent) {
457457
$log->info(get_class($event).': Starting ... ' . $event->getMaxStep() . ' (' . $event->getCurrentStepName() . ')', ['app' => 'updater']);
458458
} elseif ($event instanceof RepairAdvanceEvent) {

0 commit comments

Comments
 (0)