Check if cache is present with isset

CarlSchwan · CarlSchwan · commit 60ec5e655c34 · 2022-10-20T13:14:39.000+02:00
Otherwise we get false for empty array

Signed-off-by: Carl Schwan &lt;carl@carlschwan.eu&gt;
diff --git a/apps/user_ldap/lib/Group_LDAP.php b/apps/user_ldap/lib/Group_LDAP.php
@@ -797,7 +797,7 @@ private function getGroupsByMember(string $dn, array &$seen = []): array {
 		}
 		$seen[$dn] = true;
 
-		if ($this->cachedGroupsByMember[$dn]) {
+		if (isset($this->cachedGroupsByMember[$dn])) {
 			return $this->cachedGroupsByMember[$dn];
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -797,7 +797,7 @@ private function getGroupsByMember(string $dn, array &$seen = []): array {`
`797`	`797`	`}`
`798`	`798`	`$seen[$dn] = true;`
`799`	`799`
`800`		`- if ($this->cachedGroupsByMember[$dn]) {`
	`800`	`+ if (isset($this->cachedGroupsByMember[$dn])) {`
`801`	`801`	`return $this->cachedGroupsByMember[$dn];`
`802`	`802`	`}`
`803`	`803`