fix(l10n): Less jargon in source strings

This removes:
- “enable” for settings
- “settings” for settings sections
- “all” when there is no obvious subset of items
- “show” and “open” for navigation actions
- “changes” for applying/discarding
- “to clipboard” when copying
- Explaining things that cannot happen
- Explaining things twice, right below each other
- Redundant toast notifications
- Unnecessary technical jargon
- Text that sounds like marketing copy and serves no other purpose

Signed-off-by: kramo <git@kramo.page>

Author: kra-mo

apps/federatedfilesharing/src/components/PersonalSettings.vue

@@ -146,14 +146,14 @@ export default {
 </a>`
 		},
 		copyLinkTooltip() {
-			return this.isCopied ? t('federatedfilesharing', 'Cloud ID copied to the clipboard') : t('federatedfilesharing', 'Copy to clipboard')
+			return this.isCopied ? t('federatedfilesharing', 'Cloud ID copied') : t('federatedfilesharing', 'Copy')
 		},
 	},
 	methods: {
 		async copyCloudId(): Promise<void> {
 			try {
 				await navigator.clipboard.writeText(this.cloudId)
-				showSuccess(t('federatedfilesharing', 'Cloud ID copied to the clipboard'))
+				showSuccess(t('federatedfilesharing', 'Cloud ID copied'))
 			} catch (e) {
 				// no secure context or really old browser - need a fallback
 				window.prompt(t('federatedfilesharing', 'Clipboard not available. Please copy the cloud ID manually.'), this.reference)

apps/files/src/actions/deleteAction.ts

@@ -2,10 +2,8 @@
  * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-import { showInfo } from '@nextcloud/dialogs'
 import { Permission, Node, View, FileAction } from '@nextcloud/files'
 import { loadState } from '@nextcloud/initial-state'
-import { translate as t } from '@nextcloud/l10n'
 import PQueue from 'p-queue'
 
 import CloseSvg from '@mdi/svg/svg/close.svg?raw'
@@ -64,7 +62,6 @@ export const action = new FileAction({
 
 			// If the user cancels the deletion, we don't want to do anything
 			if (confirm === false) {
-				showInfo(t('files', 'Deletion cancelled'))
 				return null
 			}
 
@@ -88,7 +85,6 @@ export const action = new FileAction({
 
 		// If the user cancels the deletion, we don't want to do anything
 		if (confirm === false) {
-			showInfo(t('files', 'Deletion cancelled'))
 			return Promise.all(nodes.map(() => null))
 		}
 

apps/files/src/actions/moveOrCopyAction.ts

@@ -158,7 +158,6 @@ export const handleCopyMoveNodeTo = async (node: Node, destination: Folder, meth
 							}
 						} catch (error) {
 							// User cancelled
-							showError(t('files', 'Move cancelled'))
 							return
 						}
 					}
@@ -330,7 +329,6 @@ export const action = new FileAction({
 			return false
 		}
 		if (result === false) {
-			showInfo(t('files', 'Cancelled move or copy of "{filename}".', { filename: node.displayname }))
 			return null
 		}
 
@@ -352,10 +350,6 @@ export const action = new FileAction({
 		const result = await openFilePickerForAction(action, dir, nodes)
 		// Handle cancellation silently
 		if (result === false) {
-			showInfo(nodes.length === 1
-				? t('files', 'Cancelled move or copy of "{filename}".', { filename: nodes[0].displayname })
-				: t('files', 'Cancelled move or copy operation'),
-			)
 			return nodes.map(() => null)
 		}
 

apps/files/src/actions/sidebarAction.spec.ts

@@ -17,7 +17,7 @@ describe('Open sidebar action conditions tests', () => {
 	test('Default values', () => {
 		expect(action).toBeInstanceOf(FileAction)
 		expect(action.id).toBe('details')
-		expect(action.displayName([], view)).toBe('Open details')
+		expect(action.displayName([], view)).toBe('Details')
 		expect(action.iconSvgInline([], view)).toMatch(/<svg.+<\/svg>/)
 		expect(action.default).toBeUndefined()
 		expect(action.order).toBe(-50)

apps/files/src/actions/sidebarAction.ts

@@ -16,7 +16,7 @@ export const ACTION_DETAILS = 'details'
 
 export const action = new FileAction({
 	id: ACTION_DETAILS,
-	displayName: () => t('files', 'Open details'),
+	displayName: () => t('files', 'Details'),
 	iconSvgInline: () => InformationSvg,
 
 	// Sidebar currently supports user folder only, /files/USER

apps/files/src/components/FilesListTableHeaderActions.vue

@@ -305,16 +305,16 @@ export default defineComponent({
 						return
 					}
 
-					showError(this.t('files', '"{displayName}" failed on some elements', { displayName }))
+					showError(this.t('files', '{displayName}: failed on some elements', { displayName }))
 					return
 				}
 
 				// Show success message and clear selection
-				showSuccess(this.t('files', '"{displayName}" batch action executed successfully', { displayName }))
+				showSuccess(this.t('files', '{displayName}: done', { displayName }))
 				this.selectionStore.reset()
 			} catch (e) {
 				logger.error('Error while executing action', { action, e })
-				showError(this.t('files', '"{displayName}" action failed', { displayName }))
+				showError(this.t('files', '{displayName}: failed', { displayName }))
 			} finally {
 				// Remove loading markers
 				this.loading = null

apps/files/src/components/FilesNavigationSearch.vue

@@ -55,9 +55,9 @@ const isSearchView = computed(() => currentView.value.id === VIEW_ID)
  */
 const searchLabel = computed(() => {
 	if (searchStore.scope === 'globally') {
-		return t('files', 'Search globally by filename …')
+		return t('files', 'Search everywhere …')
 	}
-	return t('files', 'Search here by filename …')
+	return t('files', 'Search this location …')
 })
 </script>
 
@@ -72,13 +72,13 @@ const searchLabel = computed(() => {
 					<template #icon>
 						<NcIconSvgWrapper :path="mdiMagnify" />
 					</template>
-					{{ t('files', 'Filter and search from this location') }}
+					{{ t('files', 'Search this location') }}
 				</NcActionButton>
 				<NcActionButton close-after-click @click="searchStore.scope = 'globally'">
 					<template #icon>
 						<NcIconSvgWrapper :path="mdiSearchWeb" />
 					</template>
-					{{ t('files', 'Search globally') }}
+					{{ t('files', 'Search everywhere') }}
 				</NcActionButton>
 			</NcActions>
 		</template>

apps/files/src/filters/TypeFilter.ts

@@ -73,7 +73,7 @@ const getTypePresets = async () => [
 	{
 		id: 'image',
 		// TRANSLATORS: This is for filtering files, e.g. PNG or JPEG, so photos, drawings, or images in general
-		label: t('files', 'Photos and images'),
+		label: t('files', 'Images'),
 		icon: svgImage,
 		mime: ['image'],
 	},

apps/files/src/newMenu/newFolder.ts

@@ -8,7 +8,7 @@ import { basename } from 'path'
 import { emit } from '@nextcloud/event-bus'
 import { getCurrentUser } from '@nextcloud/auth'
 import { Permission, Folder } from '@nextcloud/files'
-import { showError, showInfo, showSuccess } from '@nextcloud/dialogs'
+import { showError, showSuccess } from '@nextcloud/dialogs'
 import { translate as t } from '@nextcloud/l10n'
 import axios from '@nextcloud/axios'
 
@@ -51,7 +51,6 @@ export const entry = {
 	async handler(context: Folder, content: Node[]) {
 		const name = await newNodeName(t('files', 'New folder'), content)
 		if (name === null) {
-			showInfo(t('files', 'New folder creation cancelled'))
 			return
 		}
 		try {

apps/files/src/utils/actionUtils.ts

@@ -59,13 +59,13 @@ export const executeAction = async (action: FileAction) => {
 		}
 
 		if (success) {
-			showSuccess(t('files', '"{displayName}" action executed successfully', { displayName }))
+			showSuccess(t('files', '{displayName}: done', { displayName }))
 			return
 		}
-		showError(t('files', '"{displayName}" action failed', { displayName }))
+		showError(t('files', '{displayName}: failed', { displayName }))
 	} catch (error) {
 		logger.error('Error while executing action', { action, error })
-		showError(t('files', '"{displayName}" action failed', { displayName }))
+		showError(t('files', '{displayName}: failed', { displayName }))
 	} finally {
 		// Reset the loading marker
 		Vue.set(currentNode, 'status', undefined)