Merge pull request #52849 from nextcloud/backport/52813/stable31

[stable31] fix(files_sharing): Show note if note exists on share

Author: nfebe

apps/files_sharing/src/views/SharingDetailsTab.vue

@@ -905,8 +905,9 @@ export default {
 				this.advancedSectionAccordionExpanded = true
 			}
 
-			if (this.share.note) {
+			if (this.isValidShareAttribute(this.share.note)) {
 				this.writeNoteToRecipientIsChecked = true
+				this.advancedSectionAccordionExpanded = true
 			}
 
 		},

cypress/e2e/files_sharing/note-to-recipient.cy.ts

@@ -80,8 +80,6 @@ describe('files_sharing: Note to recipient', { testIsolation: true }, () => {
 		cy.get('[data-cy-sidebar]').within(() => {
 			// Open the share
 			cy.get('[data-cy-files-sharing-share-actions]').first().click({ force: true })
-			// Open the custom settings
-			cy.get('[data-cy-files-sharing-share-permissions-bundle="custom"]').click()
 
 			cy.findByRole('checkbox', { name: /note to recipient/i })
 				.and('be.checked')
@@ -90,4 +88,5 @@ describe('files_sharing: Note to recipient', { testIsolation: true }, () => {
 				.and('have.value', 'Hello, this is the note.')
 		})
 	})
+
 })

dist/3421-3421.js

@@ -0,0 +1 @@
+923-923.js.license