Merge pull request #38517 from nextcloud/backport/38496/stable26

[stable26] fix: catch errors in id3parser library

Author: kesselb

lib/private/Preview/MP3.php

@@ -32,6 +32,7 @@
 
 use OCP\Files\File;
 use OCP\IImage;
+use Psr\Log\LoggerInterface;
 
 class MP3 extends ProviderV2 {
 	/**
@@ -48,8 +49,18 @@ public function getThumbnail(File $file, int $maxX, int $maxY): ?IImage {
 		$getID3 = new ID3Parser();
 
 		$tmpPath = $this->getLocalFile($file);
-		$tags = $getID3->analyze($tmpPath);
-		$this->cleanTmpFiles();
+		try {
+			$tags = $getID3->analyze($tmpPath);
+		} catch (\Throwable $e) {
+			\OC::$server->get(LoggerInterface::class)->info($e->getMessage(), [
+				'exception' => $e,
+				'app' => 'core',
+			]);
+			return null;
+		} finally {
+			$this->cleanTmpFiles();
+		}
+
 		$picture = isset($tags['id3v2']['APIC'][0]['data']) ? $tags['id3v2']['APIC'][0]['data'] : null;
 		if (is_null($picture) && isset($tags['id3v2']['PIC'][0]['data'])) {
 			$picture = $tags['id3v2']['PIC'][0]['data'];