Skip to content

Commit aca31e8

Browse files
nfebenextcloud-command
authored andcommittedMay 22, 2023
Use aria-expanded correctly on toggle user actions
The aria-expanded attribute was added on the expandable item rather Than the button that triggers the expand. Resolves : #37137 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

6 files changed

+10
-7
lines changed
 

‎apps/settings/src/components/UserList/UserRow.vue

+2
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,8 @@
220220
</NcActions>
221221
<div v-click-outside="hideMenu" class="userPopoverMenuWrapper">
222222
<button class="icon-more"
223+
:aria-expanded="openedMenu"
224+
:aria-label="t('settings', 'Toggle user actions menu')"
223225
@click.prevent="toggleMenu" />
224226
<div :class="{ 'open': openedMenu }" class="popovermenu">
225227
<NcPopoverMenu :menu="userActions" />

‎apps/settings/src/components/UserList/UserRowSimple.vue

+2-1
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,10 @@
6767
<div class="userPopoverMenuWrapper">
6868
<button v-click-outside="hideMenu"
6969
class="icon-more"
70+
:aria-expanded="openedMenu"
7071
:aria-label="t('settings', 'Toggle user actions menu')"
7172
@click.prevent="toggleMenu" />
72-
<div class="popovermenu" :class="{ 'open': openedMenu }" :aria-expanded="openedMenu">
73+
<div class="popovermenu" :class="{ 'open': openedMenu }">
7374
<NcPopoverMenu :menu="userActions" />
7475
</div>
7576
</div>

‎dist/settings-users-8351.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/settings-users-8351.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/settings-vue-settings-apps-users-management.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/settings-vue-settings-apps-users-management.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.