chore: replace cypress-delete-downloads-folder with simple implementation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

cypress.config.ts

@@ -6,10 +6,9 @@
 
 import { configureNextcloud, docker, getContainer, getContainerName, runExec, runOcc, startNextcloud, stopNextcloud, waitOnNextcloud } from '@nextcloud/e2e-test-server'
 import { defineConfig } from 'cypress'
-import { removeDirectory } from 'cypress-delete-downloads-folder'
 import cypressSplit from 'cypress-split'
 import vitePreprocessor from 'cypress-vite'
-import { existsSync } from 'node:fs'
+import { existsSync, rmdirSync } from 'node:fs'
 import { dirname, join, resolve } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { nodePolyfills } from 'vite-plugin-node-polyfills'
@@ -68,8 +67,6 @@ export default defineConfig({
 				plugins: [nodePolyfills()],
 			}))
 
-			on('task', { removeDirectory })
-
 			// This allows to store global data (e.g. the name of a snapshot)
 			// because Cypress.env() and other options are local to the current spec file.
 			const data: Record<string, unknown> = {}
@@ -81,6 +78,17 @@ export default defineConfig({
 				getVariable({ key }) {
 					return data[key] ?? null
 				},
+				// allow to clear the downloads folder
+				deleteFolder(path: string) {
+					try {
+						if (existsSync(path)) {
+							rmdirSync(path, { maxRetries: 10, recursive: true })
+						}
+						return null
+					} catch (error) {
+						throw Error(`Error while deleting ${path}. Original error: ${error}`)
+					}
+				},
 			})
 
 			// Disable spell checking to prevent rendering differences

cypress/e2e/files/files-download.cy.ts

@@ -5,8 +5,8 @@
 
 import type { User } from '@nextcloud/e2e-test-server/cypress'
 
-import { deleteDownloadsFolderBeforeEach } from 'cypress-delete-downloads-folder'
 import { zipFileContains } from '../../support/utils/assertions.ts'
+import { deleteDownloadsFolderBeforeEach } from '../../support/utils/deleteDownloadsFolder.ts'
 import { randomString } from '../../support/utils/randomString.ts'
 import { getRowForFile, navigateToFolder, triggerActionForFile } from './FilesUtils.ts'
 

cypress/e2e/files_sharing/public-share/download.cy.ts

@@ -6,9 +6,8 @@
 import type { User } from '@nextcloud/e2e-test-server/cypress'
 import type { ShareContext } from './PublicShareUtils.ts'
 
-// @ts-expect-error The package is currently broken - but works...
-import { deleteDownloadsFolderBeforeEach } from 'cypress-delete-downloads-folder'
 import { zipFileContains } from '../../../support/utils/assertions.ts'
+import { deleteDownloadsFolderBeforeEach } from '../../../support/utils/deleteDownloadsFolder.ts'
 import { getRowForFile, getRowForFileId, triggerActionForFile, triggerActionForFileId } from '../../files/FilesUtils.ts'
 import { createLinkShare, getShareUrl, openLinkShareDetails, setupPublicShare } from './PublicShareUtils.ts'
 

cypress/e2e/files_trashbin/files.cy.ts

@@ -5,13 +5,12 @@
 
 import type { User } from '@nextcloud/e2e-test-server/cypress'
 
-// @ts-expect-error package has wrong typings
-import { deleteDownloadsFolderBeforeEach } from 'cypress-delete-downloads-folder'
+import { deleteDownloadsFolderBeforeEach } from '../../support/utils/deleteDownloadsFolder.ts'
 import { deleteFileWithRequest, getRowForFileId, selectAllFiles, triggerActionForFileId } from '../files/FilesUtils.ts'
 
 describe('files_trashbin: download files', { testIsolation: true }, () => {
 	let user: User
-	const fileids: number[] = []
+	const fileids: [number, number] = [0, 0]
 
 	deleteDownloadsFolderBeforeEach()
 
@@ -20,10 +19,10 @@ describe('files_trashbin: download files', { testIsolation: true }, () => {
 			user = $user
 
 			cy.uploadContent(user, new Blob(['<content>']), 'text/plain', '/file.txt')
-				.then(({ headers }) => fileids.push(Number.parseInt(headers['oc-fileid'])))
+				.then(({ headers }) => fileids[0] = Number.parseInt(headers['oc-fileid']))
 				.then(() => deleteFileWithRequest(user, '/file.txt'))
 			cy.uploadContent(user, new Blob(['<content>']), 'text/plain', '/other-file.txt')
-				.then(({ headers }) => fileids.push(Number.parseInt(headers['oc-fileid'])))
+				.then(({ headers }) => fileids[1] = Number.parseInt(headers['oc-fileid']))
 				.then(() => deleteFileWithRequest(user, '/other-file.txt'))
 		})
 	})

cypress/support/utils/deleteDownloadsFolder.ts

@@ -0,0 +1,11 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+/**
+ * Ensure the downloads folder is deleted before each test
+ */
+export function deleteDownloadsFolderBeforeEach() {
+	beforeEach(() => cy.task('deleteFolder', Cypress.config('downloadsFolder')))
+}