Merge pull request #33311 from nextcloud/enh/27869/phone

Remake phone number property saving with Vue

Author: PVince81

apps/settings/js/federationsettingsview.js

@@ -133,7 +133,8 @@
 					field === 'displayname' ||
 					field === 'twitter' ||
 					field === 'address' ||
-					field === 'website'
+					field === 'website' ||
+					field === 'phone'
 				) {
 					return;
 				}

apps/settings/lib/Settings/Personal/PersonalInfo.php

@@ -147,8 +147,6 @@ public function getForm(): TemplateResponse {
 			'federationEnabled' => $federationEnabled,
 			'lookupServerUploadEnabled' => $lookupServerUploadEnabled,
 			'avatarScope' => $account->getProperty(IAccountManager::PROPERTY_AVATAR)->getScope(),
-			'phone' => $account->getProperty(IAccountManager::PROPERTY_PHONE)->getValue(),
-			'phoneScope' => $account->getProperty(IAccountManager::PROPERTY_PHONE)->getScope(),
 			'groups' => $this->getGroups($user),
 			'isFairUseOfFreePushService' => $this->isFairUseOfFreePushService(),
 			'profileEnabledGlobally' => $this->profileManager->isProfileEnabled(),
@@ -158,6 +156,7 @@ public function getForm(): TemplateResponse {
 			'userId' => $uid,
 			'displayName' => $this->getProperty($account, IAccountManager::PROPERTY_DISPLAYNAME),
 			'emailMap' => $this->getEmailMap($account),
+			'phone' => $this->getProperty($account, IAccountManager::PROPERTY_PHONE),
 			'location' => $this->getProperty($account, IAccountManager::PROPERTY_ADDRESS),
 			'website' => $this->getProperty($account, IAccountManager::PROPERTY_WEBSITE),
 			'twitter' => $this->getProperty($account, IAccountManager::PROPERTY_TWITTER),

apps/settings/src/components/PersonalInfo/PhoneSection.vue

@@ -0,0 +1,59 @@
+<!--
+	- @copyright 2022 Christopher Ng <chrng8@gmail.com>
+	-
+	- @author Christopher Ng <chrng8@gmail.com>
+	-
+	- @license AGPL-3.0-or-later
+	-
+	- This program is free software: you can redistribute it and/or modify
+	- it under the terms of the GNU Affero General Public License as
+	- published by the Free Software Foundation, either version 3 of the
+	- License, or (at your option) any later version.
+	-
+	- This program is distributed in the hope that it will be useful,
+	- but WITHOUT ANY WARRANTY; without even the implied warranty of
+	- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+	- GNU Affero General Public License for more details.
+	-
+	- You should have received a copy of the GNU Affero General Public License
+	- along with this program. If not, see <http://www.gnu.org/licenses/>.
+	-
+-->
+
+<template>
+	<AccountPropertySection v-bind.sync="phone"
+		:placeholder="t('settings', 'Your phone number')"
+		type="tel"
+		:on-validate="onValidate" />
+</template>
+
+<script>
+import { isValidPhoneNumber } from 'libphonenumber-js'
+import { loadState } from '@nextcloud/initial-state'
+
+import AccountPropertySection from './shared/AccountPropertySection.vue'
+
+import { NAME_READABLE_ENUM } from '../../constants/AccountPropertyConstants.js'
+
+const { phone } = loadState('settings', 'personalInfoParameters', {})
+
+export default {
+	name: 'PhoneSection',
+
+	components: {
+		AccountPropertySection,
+	},
+
+	data() {
+		return {
+			phone: { ...phone, readable: NAME_READABLE_ENUM[phone.name] },
+		}
+	},
+
+	methods: {
+		onValidate(value) {
+			return isValidPhoneNumber(value)
+		},
+	},
+}
+</script>

apps/settings/src/main-personal-info.js

@@ -28,6 +28,7 @@ import '@nextcloud/dialogs/styles/toast.scss'
 
 import DisplayNameSection from './components/PersonalInfo/DisplayNameSection.vue'
 import EmailSection from './components/PersonalInfo/EmailSection/EmailSection.vue'
+import PhoneSection from './components/PersonalInfo/PhoneSection.vue'
 import LocationSection from './components/PersonalInfo/LocationSection.vue'
 import WebsiteSection from './components/PersonalInfo/WebsiteSection.vue'
 import TwitterSection from './components/PersonalInfo/TwitterSection.vue'
@@ -51,13 +52,15 @@ Vue.mixin({
 
 const DisplayNameView = Vue.extend(DisplayNameSection)
 const EmailView = Vue.extend(EmailSection)
+const PhoneView = Vue.extend(PhoneSection)
 const LocationView = Vue.extend(LocationSection)
 const WebsiteView = Vue.extend(WebsiteSection)
 const TwitterView = Vue.extend(TwitterSection)
 const LanguageView = Vue.extend(LanguageSection)
 
 new DisplayNameView().$mount('#vue-displayname-section')
 new EmailView().$mount('#vue-email-section')
+new PhoneView().$mount('#vue-phone-section')
 new LocationView().$mount('#vue-location-section')
 new WebsiteView().$mount('#vue-website-section')
 new TwitterView().$mount('#vue-twitter-section')

apps/settings/templates/settings/personal/personal.info.php

@@ -120,20 +120,7 @@
 			<div id="vue-email-section"></div>
 		</div>
 		<div class="personal-settings-setting-box">
-			<form id="phoneform" class="section">
-				<h3>
-					<label for="phone"><?php p($l->t('Phone number')); ?></label>
-					<a href="#" class="federation-menu" aria-label="<?php p($l->t('Change privacy level of phone number')); ?>">
-						<span class="icon-federation-menu icon-password">
-							<span class="icon-triangle-s"></span>
-						</span>
-					</a>
-				</h3>
-				<input type="tel" id="phone" name="phone" value="<?php p($_['phone']) ?>" placeholder="<?php p($l->t('Your phone number')); ?>" autocomplete="on" autocapitalize="none" autocorrect="off" />
-				<span class="icon-checkmark hidden"></span>
-				<span class="icon-error hidden"></span>
-				<input type="hidden" id="phonescope" value="<?php p($_['phoneScope']) ?>">
-			</form>
+			<div id="vue-phone-section"></div>
 		</div>
 		<div class="personal-settings-setting-box">
 			<div id="vue-location-section"></div>

dist/core-common.js

@@ -69,6 +69,7 @@
     "jquery-ui": "^1.13.2",
     "jquery-ui-dist": "^1.13.1",
     "jstimezonedetect": "^1.0.7",
+    "libphonenumber-js": "^1.10.13",
     "lodash": "^4.17.21",
     "marked": "^4.0.14",
     "moment": "^2.29.2",