feat(internal-link): avoid re-writing of the new fileid

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Author: ArtificialOwl

apps/files/lib/Controller/ViewController.php

@@ -92,8 +92,8 @@ public function showFile(?string $fileid = null, ?string $opendetails = null, ?s
 		try {
 			$event = new InternalLinkRequestEvent($fileid);
 			$this->eventDispatcher->dispatchTyped($event);
-			
-			return $event->getResponse() ?? $this->redirectToFile((int)$fileid, $opendetails, $openfile);
+
+			return $event->getResponse() ?? $this->redirectToFile((int)($event->getNewFileId() ?? $fileid), $opendetails, $openfile);
 		} catch (NotFoundException $e) {
 			// Keep the fileid even if not found, it will be used
 			// to detect the file could not be found and warn the user

lib/public/Files/Events/InternalLinkRequestEvent.php

@@ -8,45 +8,79 @@
  */
 namespace OCP\Files\Events;
 
+use OCA\Files\Controller\ViewController;
 use OCP\AppFramework\Http\Response;
 use OCP\EventDispatcher\Event;
+use OCP\Server;
+use Psr\Log\LoggerInterface;
 
 /**
+ * Allow a modification of the behavior on internal-link request ('/index.php/f/12345')
+ *
+ * A listener can change the value of the FileId or even force a new Response() to be sent back to the client.
+ *
+ * @see ViewController::showFile
  * @since 32.0.0
  */
 class InternalLinkRequestEvent extends Event {
 	private ?Response $response = null;
+	private ?string $newFileId = null;
 	/**
 	 * @since 32.0.0
 	 */
 	public function __construct(
-		private string &$fileId,
+		private readonly string $fileId,
 	) {
 		parent::__construct();
 	}
 
 	/**
+	 * returns the original fileId
+
 	 * @since 32.0.0
 	 */
-	public function setFileId(string $fileId): void {
-		$this->fileId = $fileId;
+	public function getFileId(): string {
+		return $this->fileId;
 	}
 
 	/**
+	 * Set a new fileId that will be used by the original RedirectResponse
+	 *
 	 * @since 32.0.0
 	 */
-	public function getFileId(): string {
-		return $this->fileId;
+	public function setNewFileId(string $fileId): void {
+		if ($this->newFileId === null) {
+			$this->newFileId = $fileId;
+		} else {
+			Server::get(LoggerInterface::class)->notice('a new file id was already set', ['exception' => new \Exception('')]);
+		}
+	}
+
+	/**
+	 * return new fileId, or NULL if not defined
+	 *
+	 * @since 32.0.0
+	 */
+	public function getNewFileId(): ?string {
+		return $this->newFileId;
 	}
 
 	/**
+	 * set a new Response
+	 *
 	 * @since 32.0.0
 	 */
 	public function setResponse(Response $response): void {
-		$this->response = $response;
+		if ($this->response === null) {
+			$this->response = $response;
+		} else {
+			Server::get(LoggerInterface::class)->notice('a Response was already set', ['exception' => new \Exception('')]);
+		}
 	}
 
 	/**
+	 * return the new response to send back to client
+	 *
 	 * @since 32.0.0
 	 */
 	public function getResponse(): ?Response {