-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make trashbin:cleanup clean all users an explicit option not the default #10001
Labels
Milestone
Comments
I will take a crack at making a PR myself, but I've never worked on a production-grade PHP project so will likely be very poor quality |
nextcloud-bot
added
enhancement
stale
Ticket or PR with no recent activity
and removed
stale
Ticket or PR with no recent activity
labels
Jun 26, 2018
Don't worry - we can assist once you have questions. Feel free to join IRC at freenode: #nextcloud-dev |
Fixed by #10041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
php ./occ trashbin:cleanup <user>
cleans one userphp ./occ trashbin:cleanup
cleans all usersExpected behaviour
Actual behaviour
Server configuration
Core component "files" on NC13.0.4
Operating system:
All
Web server:
All
Database:
All
PHP version:
All
Nextcloud version: (see Nextcloud admin page)
13.0.4
Comments
The default behaviour (the fall-through) is more dangerous than the specific case. e.g.
user:disable
without parameters doesn't disable all users, but throws an exception. Thetrashbin:cleanup
command should also fall through safely without parameters.trashbin:cleanup --all(-users)
.The text was updated successfully, but these errors were encountered: