Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all preview providers which require Imagemagick to an app #1041

Open
oparoz opened this issue Aug 24, 2016 · 8 comments
Open

Move all preview providers which require Imagemagick to an app #1041

oparoz opened this issue Aug 24, 2016 · 8 comments
Assignees
Labels

Comments

@oparoz
Copy link
Member

oparoz commented Aug 24, 2016

All the preview providers which require Imagemagick are disabled by default. I propose we move them to an app.

Phase 1

  • Keep config in config/config.php
  • Create app with all the current providers

Phase 2

  • Move config to a config file in the app folder in order to decouple it from the server?
  • Introduce some extra providers

Phase 3

  • Enable/disable providers from the admin section?

@LukasReschke @nickvergessen @rullzer @icewind1991 @karlitschek

@oparoz oparoz added this to the Nextcloud 11.0 milestone Aug 24, 2016
@oparoz oparoz self-assigned this Aug 24, 2016
@nickvergessen
Copy link
Member

Phase 1: yes
Phase 2: oc_appconfig, no config files for apps, those are deleted on update :-O

@oparoz
Copy link
Member Author

oparoz commented Aug 24, 2016

those are deleted on update

Not if we use the fancy new filesystem in development which can store app related files, no?

@nickvergessen
Copy link
Member

App configuration belongs in the named DB table, not in a file. config.php should also be migrated to the database. Otherwise you run into issues with load balancing if both servers have a different config file (happened in the past).
So please just use the DB and done.

@rullzer
Copy link
Member

rullzer commented Aug 24, 2016

YES!!! 👍

And indeed keep it in the DB please :)

@karlitschek
Copy link
Member

O.K. We can do this but the app should still stay in the core repo and should be shipped by default. Feature regressions are bad.

@oparoz
Copy link
Member Author

oparoz commented Aug 25, 2016

O.K. We can do this but the app should still stay in the core repo and should be shipped by default. Feature regressions are bad.

Agreed

@rullzer
Copy link
Member

rullzer commented Aug 25, 2016

Fine by me 😄

@MorrisJobke MorrisJobke removed this from the Nextcloud 13 milestone Nov 13, 2017
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 12, 2019
@skjnldsv skjnldsv added feature: previews and thumbnails stale Ticket or PR with no recent activity labels Jun 12, 2019
@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 12, 2019
@szaimen
Copy link
Contributor

szaimen commented May 21, 2021

I suppose this issue is still valid? If not, please close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants