Add to favorites missing in "Recent" and main "Shares" view

[ogasser]

The "Add to favorites" item in the three dots menu is missing in the "Recent" view.

Steps to reproduce

1. Click on "Recent" in the left sidebar
2. Click on the three dot menu of any file

Expected behaviour

The three dot menu in the "Recent" view should contain the "Add to favorites" item, as it does with the "All files" view.

Actual behaviour

The three dot menu in the "Recent" does not contain the "Add to favorites" item.

[nextcloud-bot]

GitMate.io thinks possibly related issues are #10398 (Opening details after coming from favorites view is broken), #7627 (Add multiple files to favorites ), #7379 (Re-think position of "Add to favorites"), #4697 (Files: show favorites column in Recent view as well), and #2193 (Files: show favorites column in Shared views as well).

[jancborchardt]

Yup, same in the main "Shares" view. The entry in the popover menu does not exist while all others do.

cc @icewind1991 @juliushaertl @schiessle, or cc the person who is relevant to this. ;)

[jancborchardt]

@nextcloud/javascript this is a quite core inconsistency with the views. Seems like a papercut with a possible easy fix?

[MorrisJobke]

Let's look into this for 15.0.1

[szaimen]

I could reproduce this on NC21.0.1

[szaimen]

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!