Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging not working stable on cloud.nextcloud.com #10774

Closed
mathiasconradt opened this issue Aug 21, 2018 · 30 comments · Fixed by #10782
Closed

Tagging not working stable on cloud.nextcloud.com #10774

mathiasconradt opened this issue Aug 21, 2018 · 30 comments · Fixed by #10782
Assignees
Milestone

Comments

@mathiasconradt
Copy link

Tagging files does not always work on cloud.nextcloud.com, current version as of 21.08.2018

Expected behaviour:

Tags show including the input field to add more tags

Actual behaviour:

Nothing happens upon click, not even any JS error in the dev console.

This only happen sometimes, sometimes it works.

How to reproduce it:

Reload the browser page with Nextcloud file explorer in a folder that contains multiple files.
Open document details of one file, click on "Tags": the tag input box appears.
Now open the document details of another file (without reloading the browser!), click on "Tags": the tag input box does not appear.

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #7801 (Nextcloud Talk APP NOT Working), #5391 (2fa TOTP stopped working on Nextcloud 12), #8310 (Disable web app by own cloud interface (NO NEXTCLOUD THEME)), #8348 (Server error response (nextcloud.com down)), and #8767 (After the update the nextcloud server is not longer working).

@MorrisJobke
Copy link
Member

@mathiasconradt I sadly can't reproduce, but will retry. Could you open the web developer console (Ctrl + F12) in your browser and then reload the page. If it doesn't work it maybe show something in the "Console" tab. That would be useful.

@MorrisJobke
Copy link
Member

@juliushaertl @skjnldsv @blizzz for the JS part of tags

@mathiasconradt
Copy link
Author

mathiasconradt commented Aug 21, 2018

@MorrisJobke Enabled dev console, even "disable cache" is activated. Still able to reproduce the error. I can show it to you via NC Talk Screenshare if you or others want, just ping me.

Tested with FF and Chrome latest versions, on Ubuntu/Gnome.

@blizzz
Copy link
Member

blizzz commented Aug 21, 2018

@mathiasconradt cannot reproduce it either. What does the POST request to https://cloud.nextcloud.com/remote.php/dav/systemtags/ result in?

@mathiasconradt
Copy link
Author

There is no POST request in the devl tools, only a PROPFIND

The response of the first PROPFIND returns proper values:

PROPFIND https://cloud.nextcloud.com/remote.php/dav/systemtags/

<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns"><d:response><d:href>/remote.php/dav/systemtags/</d:href><d:propstat><d:prop><oc:id/><oc:display-name/><oc:user-visible/><oc:user-assignable/><oc:can-assign/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/6</d:href><d:propstat><d:prop><oc:id>6</oc:id><oc:display-name>Invoice</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/9</d:href><d:propstat><d:prop><oc:id>9</oc:id><oc:display-name>Marketing</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/7</d:href><d:propstat><d:prop><oc:id>7</oc:id><oc:display-name>RESTRICTED</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/8</d:href><d:propstat><d:prop><oc:id>8</oc:id><oc:display-name>fujitsu</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/3</d:href><d:propstat><d:prop><oc:id>3</oc:id><oc:display-name>pi</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/5</d:href><d:propstat><d:prop><oc:id>5</oc:id><oc:display-name>review</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/1</d:href><d:propstat><d:prop><oc:id>1</oc:id><oc:display-name>snap</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/10</d:href><d:propstat><d:prop><oc:id>10</oc:id><oc:display-name>test</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/11</d:href><d:propstat><d:prop><oc:id>11</oc:id><oc:display-name>test2</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/2</d:href><d:propstat><d:prop><oc:id>2</oc:id><oc:display-name>ubuntu core</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/systemtags/4</d:href><d:propstat><d:prop><oc:id>4</oc:id><oc:display-name>work in progress</oc:display-name><oc:user-visible>true</oc:user-visible><oc:user-assignable>true</oc:user-assignable><oc:can-assign>true</oc:can-assign></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response></d:multistatus>

PROPFINDs on the documents itself:

PROPFIND https://cloud.nextcloud.com/remote.php/dav/systemtags-relations/files/755194

Reponse:

<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns"><d:response><d:href>/remote.php/dav/systemtags-relations/files/755194/</d:href><d:propstat><d:prop><oc:id/><oc:display-name/><oc:user-visible/><oc:user-assignable/><oc:can-assign/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response></d:multistatus>

I get the 404 in both cases: where the tag on a document works and where it doesn't.

@blizzz
Copy link
Member

blizzz commented Aug 21, 2018

A POST should be fired when a tag was set, that's what happening for me.

Do you own that file or is it a shared one?

@mathiasconradt
Copy link
Author

I'm not setting a tag (yet), I just click on "tag" word in order to open the tag input field. And that already does not always work, even before I submit any tag.
I can do a screenshare to show you.

@blizzz
Copy link
Member

blizzz commented Aug 21, 2018

OK, tried it again, clicking on Tags to get into the text input works for the first file (more precise: for the first file of which I open the sidebar) after a page load, but not any other, and also not when returning to the first file. Seems the click action is assigned once, but not any further.

@blizzz
Copy link
Member

blizzz commented Aug 21, 2018

It's a backbone view and it seems that the click-event-binding get's lost.

@MorrisJobke
Copy link
Member

Reload the browser page with Nextcloud file explorer in a folder that contains multiple files.
Open document details of one file, click on "Tags": the tag input box appears.
Now open the document details of another file (without reloading the browser!), click on "Tags": the tag input box does not appear.

@mathiasconradt Is it this behavior: https://cloud.morrisjobke.de/s/B5CJKcNHbWKAyQa ?

@blizzz
Copy link
Member

blizzz commented Aug 22, 2018

@MorrisJobke nope, the tag list does not even open for him on the second file

@blizzz
Copy link
Member

blizzz commented Aug 22, 2018

fix in #10782

@SNAKE83
Copy link

SNAKE83 commented Sep 21, 2018

Hi, any updates on solution to this problem?
I just installed NC14, few times, cause I could not understand what is happening, but it does not work.
Tag "link/button" works only once on page reload, after being used on one file, it does not open until page reload.

@blizzz
Copy link
Member

blizzz commented Sep 21, 2018

@SNAKE83 #10782 is not merged yet, thus there isn't any backport to 14. → 14.0.2 is the next candidate.

@SNAKE83
Copy link

SNAKE83 commented Sep 21, 2018

@SNAKE83 #10782 is not merged yet, thus there isn't any backport to 14. → 14.0.2 is the next candidate.
👍 Thank You, so there is hope :)

@MorrisJobke
Copy link
Member

Fix was reverted as it broke the sharing entries -> reopen

@MorrisJobke MorrisJobke reopened this Oct 9, 2018
@Troublicious
Copy link

I can confirm the problem still exists in 14.0.2

@RuudschMaHinda
Copy link
Member

Confirming this still existing in 14.0.3

@DBJRdev
Copy link

DBJRdev commented Oct 23, 2018

We encounter the same problem, appearing on two different NC instances (both NC 14.0.3, one updated since NC 12.x, the other started with NC 14), we tested with

  • Firefox 62 on Windows 7
  • Firefox 63 on Ubuntu 18.10
  • Chrome 69 on both systems.
  • Chrome Ver. 70.0.3538.67 (32-Bit)
  • Opera Ver. 56.0.3051.52 (32-Bit)
  • Internet Explorer 11

@SNAKE83
Copy link

SNAKE83 commented Nov 6, 2018

Any idea how to fix it?
Only way is to get back to older version?

@RuudschMaHinda
Copy link
Member

#12231 I think this is related and might fix it. Can't test it right now though.

@violoncelloCH
Copy link
Member

violoncelloCH commented Nov 7, 2018

#12231 unfortunately doesn't fix this (tested with current master) but makes it worse (tags not working at all) but as this follow-up issue got recognized in #12320 we can hopefully expect a fix soon

@ghost
Copy link

ghost commented Nov 10, 2018

Bug present on 14.0.3 production too.

@SNAKE83
Copy link

SNAKE83 commented Nov 13, 2018

How could it be released with a bug of something that was working earlier?
This is a very weird policy, makes You think what else is not working as supposed to be, maybe security?

@ghost
Copy link

ghost commented Nov 14, 2018

How could it be released with a bug of something that was working earlier?

@SNAKE83 Evolve code without have any bug is a difficult art. (especially with framework/library, engines and hardware who evolve too)

@MorrisJobke
Copy link
Member

Most likely fixed by #12577. The backport will come to 14.0.5.

@SNAKE83
Copy link

SNAKE83 commented Dec 13, 2018

Working in 15.0.0

@TueTchen
Copy link

Please Re-Open for 18.0.4 (just updated from 18.0.3).
In 18.0.3 it happened "sometimes" but often could be solved by refresh, sometimes by re-login.
But now I'm not able to Tag new files anymore.
Thank you for soon solutions in advance - yours, Peter alias TueTchen, Germany

@blizzz
Copy link
Member

blizzz commented Apr 24, 2020

This is one and a half-year old. Please open a new issue with full details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants